summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHaelwenn (lanodan) Monnier <contact@hacktivis.me>2023-04-18 00:07:39 +0200
committerHaelwenn (lanodan) Monnier <contact@hacktivis.me>2023-04-18 00:12:42 +0200
commit2148ef5e2fcced6a52f0cfda38abcf697698dd1a (patch)
treebd6ebf91d70334d93475d641e6695c223157e533
parent8f0f58e28b58cd9a4a05f1b927aa24fd63f9a3bd (diff)
downloadpleroma-2148ef5e2fcced6a52f0cfda38abcf697698dd1a.tar.gz
pleroma-2148ef5e2fcced6a52f0cfda38abcf697698dd1a.zip
UploadedMedia: Increase readability via ~s sigil
-rw-r--r--lib/pleroma/web/plugs/uploaded_media.ex4
-rw-r--r--test/pleroma/web/plugs/uploaded_media_plug_test.exs4
2 files changed, 4 insertions, 4 deletions
diff --git a/lib/pleroma/web/plugs/uploaded_media.ex b/lib/pleroma/web/plugs/uploaded_media.ex
index 71d8f2f74..8b3bc9acb 100644
--- a/lib/pleroma/web/plugs/uploaded_media.ex
+++ b/lib/pleroma/web/plugs/uploaded_media.ex
@@ -35,9 +35,9 @@ defmodule Pleroma.Web.Plugs.UploadedMedia do
conn =
case fetch_query_params(conn) do
%{query_params: %{"name" => name}} = conn ->
- name = String.replace(name, "\"", "\\\"")
+ name = String.replace(name, ~s["], ~s[\\"])
- put_resp_header(conn, "content-disposition", "inline; filename=\"#{name}\"")
+ put_resp_header(conn, "content-disposition", ~s[inline; filename="#{name}"])
conn ->
conn
diff --git a/test/pleroma/web/plugs/uploaded_media_plug_test.exs b/test/pleroma/web/plugs/uploaded_media_plug_test.exs
index 99ba49d37..8323ff6ab 100644
--- a/test/pleroma/web/plugs/uploaded_media_plug_test.exs
+++ b/test/pleroma/web/plugs/uploaded_media_plug_test.exs
@@ -33,11 +33,11 @@ defmodule Pleroma.Web.Plugs.UploadedMediaPlugTest do
test "sends Content-Disposition header when name param is set", %{
attachment_url: attachment_url
} do
- conn = get(build_conn(), attachment_url <> "?name=\"cofe\".gif")
+ conn = get(build_conn(), attachment_url <> ~s[?name="cofe".gif])
assert Enum.any?(
conn.resp_headers,
- &(&1 == {"content-disposition", "inline; filename=\"\\\"cofe\\\".gif\""})
+ &(&1 == {"content-disposition", ~s[inline; filename="\\"cofe\\".gif"]})
)
end
end