summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--lib/pleroma/web/twitter_api/twitter_api.ex13
-rw-r--r--lib/pleroma/web/twitter_api/twitter_api_controller.ex10
-rw-r--r--test/web/twitter_api/twitter_api_test.exs17
3 files changed, 31 insertions, 9 deletions
diff --git a/lib/pleroma/web/twitter_api/twitter_api.ex b/lib/pleroma/web/twitter_api/twitter_api.ex
index 735d88832..de76822fc 100644
--- a/lib/pleroma/web/twitter_api/twitter_api.ex
+++ b/lib/pleroma/web/twitter_api/twitter_api.ex
@@ -103,8 +103,8 @@ defmodule Pleroma.Web.TwitterAPI.TwitterAPI do
end
end
- def follow(%User{} = follower, followed_id) do
- with %User{} = followed <- Repo.get(User, followed_id),
+ def follow(%User{} = follower, params) do
+ with %User{} = followed <- get_user(params),
{ :ok, follower } <- User.follow(follower, followed),
{ :ok, activity } <- ActivityPub.insert(%{
"type" => "Follow",
@@ -290,4 +290,13 @@ defmodule Pleroma.Web.TwitterAPI.TwitterAPI do
defp make_date do
DateTime.utc_now() |> DateTime.to_iso8601
end
+
+ defp get_user(params) do
+ case params do
+ %{ "user_id" => user_id } ->
+ Repo.get(User, user_id)
+ %{ "screen_name" => nickname } ->
+ Repo.get_by(User, nickname: nickname)
+ end
+ end
end
diff --git a/lib/pleroma/web/twitter_api/twitter_api_controller.ex b/lib/pleroma/web/twitter_api/twitter_api_controller.ex
index b0287a7f4..429417884 100644
--- a/lib/pleroma/web/twitter_api/twitter_api_controller.ex
+++ b/lib/pleroma/web/twitter_api/twitter_api_controller.ex
@@ -45,19 +45,19 @@ defmodule Pleroma.Web.TwitterAPI.Controller do
|> json_reply(200, json)
end
- def follow(%{assigns: %{user: user}} = conn, %{ "user_id" => followed_id }) do
- { :ok, user, follower, _activity } = TwitterAPI.follow(user, followed_id)
+ def follow(%{assigns: %{user: user}} = conn, params) do
+ { :ok, user, followed, _activity } = TwitterAPI.follow(user, params)
- response = follower |> UserRepresenter.to_json(%{for: user})
+ response = followed |> UserRepresenter.to_json(%{for: user})
conn
|> json_reply(200, response)
end
def unfollow(%{assigns: %{user: user}} = conn, %{ "user_id" => followed_id }) do
- { :ok, user, follower } = TwitterAPI.unfollow(user, followed_id)
+ { :ok, user, followed } = TwitterAPI.unfollow(user, followed_id)
- response = follower |> UserRepresenter.to_json(%{for: user})
+ response = followed |> UserRepresenter.to_json(%{for: user})
conn
|> json_reply(200, response)
diff --git a/test/web/twitter_api/twitter_api_test.exs b/test/web/twitter_api/twitter_api_test.exs
index 1e5204db8..67b47163d 100644
--- a/test/web/twitter_api/twitter_api_test.exs
+++ b/test/web/twitter_api/twitter_api_test.exs
@@ -112,11 +112,24 @@ defmodule Pleroma.Web.TwitterAPI.TwitterAPITest do
assert status == ActivityRepresenter.to_map(activity, %{for: user, user: actor})
end
- test "Follow another user" do
+ test "Follow another user using user_id" do
user = insert(:user)
following = insert(:user)
- {:ok, user, following, activity } = TwitterAPI.follow(user, following.id)
+ {:ok, user, following, activity } = TwitterAPI.follow(user, %{"user_id" => following.id})
+
+ user = Repo.get(User, user.id)
+ follow = Repo.get(Activity, activity.id)
+
+ assert user.following == [User.ap_followers(following)]
+ assert follow == activity
+ end
+
+ test "Follow another user using screen_name" do
+ user = insert(:user)
+ following = insert(:user)
+
+ {:ok, user, following, activity } = TwitterAPI.follow(user, %{"screen_name" => following.nickname})
user = Repo.get(User, user.id)
follow = Repo.get(Activity, activity.id)