diff options
Diffstat (limited to 'test')
| -rw-r--r-- | test/web/admin_api/admin_api_controller_test.exs | 40 | ||||
| -rw-r--r-- | test/web/admin_api/views/report_view_test.exs | 18 | ||||
| -rw-r--r-- | test/web/common_api/common_api_test.exs | 30 | ||||
| -rw-r--r-- | test/web/mastodon_api/controllers/report_controller_test.exs | 24 | 
4 files changed, 60 insertions, 52 deletions
diff --git a/test/web/admin_api/admin_api_controller_test.exs b/test/web/admin_api/admin_api_controller_test.exs index f80dbf8dd..1862a9589 100644 --- a/test/web/admin_api/admin_api_controller_test.exs +++ b/test/web/admin_api/admin_api_controller_test.exs @@ -1347,9 +1347,9 @@ defmodule Pleroma.Web.AdminAPI.AdminAPIControllerTest do        {:ok, %{id: report_id}} =          CommonAPI.report(reporter, %{ -          "account_id" => target_user.id, -          "comment" => "I feel offended", -          "status_ids" => [activity.id] +          account_id: target_user.id, +          comment: "I feel offended", +          status_ids: [activity.id]          })        response = @@ -1374,16 +1374,16 @@ defmodule Pleroma.Web.AdminAPI.AdminAPIControllerTest do        {:ok, %{id: report_id}} =          CommonAPI.report(reporter, %{ -          "account_id" => target_user.id, -          "comment" => "I feel offended", -          "status_ids" => [activity.id] +          account_id: target_user.id, +          comment: "I feel offended", +          status_ids: [activity.id]          })        {:ok, %{id: second_report_id}} =          CommonAPI.report(reporter, %{ -          "account_id" => target_user.id, -          "comment" => "I feel very offended", -          "status_ids" => [activity.id] +          account_id: target_user.id, +          comment: "I feel very offended", +          status_ids: [activity.id]          })        %{ @@ -1523,9 +1523,9 @@ defmodule Pleroma.Web.AdminAPI.AdminAPIControllerTest do        {:ok, %{id: report_id}} =          CommonAPI.report(reporter, %{ -          "account_id" => target_user.id, -          "comment" => "I feel offended", -          "status_ids" => [activity.id] +          account_id: target_user.id, +          comment: "I feel offended", +          status_ids: [activity.id]          })        response = @@ -1547,15 +1547,15 @@ defmodule Pleroma.Web.AdminAPI.AdminAPIControllerTest do        {:ok, %{id: first_report_id}} =          CommonAPI.report(reporter, %{ -          "account_id" => target_user.id, -          "comment" => "I feel offended", -          "status_ids" => [activity.id] +          account_id: target_user.id, +          comment: "I feel offended", +          status_ids: [activity.id]          })        {:ok, %{id: second_report_id}} =          CommonAPI.report(reporter, %{ -          "account_id" => target_user.id, -          "comment" => "I don't like this user" +          account_id: target_user.id, +          comment: "I don't like this user"          })        CommonAPI.update_report_state(second_report_id, "closed") @@ -3431,9 +3431,9 @@ defmodule Pleroma.Web.AdminAPI.AdminAPIControllerTest do        {:ok, %{id: report_id}} =          CommonAPI.report(reporter, %{ -          "account_id" => target_user.id, -          "comment" => "I feel offended", -          "status_ids" => [activity.id] +          account_id: target_user.id, +          comment: "I feel offended", +          status_ids: [activity.id]          })        post(conn, "/api/pleroma/admin/reports/#{report_id}/notes", %{ diff --git a/test/web/admin_api/views/report_view_test.exs b/test/web/admin_api/views/report_view_test.exs index 5db6629f2..8cfa1dcfa 100644 --- a/test/web/admin_api/views/report_view_test.exs +++ b/test/web/admin_api/views/report_view_test.exs @@ -15,7 +15,7 @@ defmodule Pleroma.Web.AdminAPI.ReportViewTest do      user = insert(:user)      other_user = insert(:user) -    {:ok, activity} = CommonAPI.report(user, %{"account_id" => other_user.id}) +    {:ok, activity} = CommonAPI.report(user, %{account_id: other_user.id})      expected = %{        content: nil, @@ -48,7 +48,7 @@ defmodule Pleroma.Web.AdminAPI.ReportViewTest do      {:ok, activity} = CommonAPI.post(other_user, %{"status" => "toot"})      {:ok, report_activity} = -      CommonAPI.report(user, %{"account_id" => other_user.id, "status_ids" => [activity.id]}) +      CommonAPI.report(user, %{account_id: other_user.id, status_ids: [activity.id]})      other_user = Pleroma.User.get_by_id(other_user.id) @@ -81,7 +81,7 @@ defmodule Pleroma.Web.AdminAPI.ReportViewTest do      user = insert(:user)      other_user = insert(:user) -    {:ok, activity} = CommonAPI.report(user, %{"account_id" => other_user.id}) +    {:ok, activity} = CommonAPI.report(user, %{account_id: other_user.id})      {:ok, activity} = CommonAPI.update_report_state(activity.id, "closed")      assert %{state: "closed"} = @@ -94,8 +94,8 @@ defmodule Pleroma.Web.AdminAPI.ReportViewTest do      {:ok, activity} =        CommonAPI.report(user, %{ -        "account_id" => other_user.id, -        "comment" => "posts are too good for this instance" +        account_id: other_user.id, +        comment: "posts are too good for this instance"        })      assert %{content: "posts are too good for this instance"} = @@ -108,8 +108,8 @@ defmodule Pleroma.Web.AdminAPI.ReportViewTest do      {:ok, activity} =        CommonAPI.report(user, %{ -        "account_id" => other_user.id, -        "comment" => "" +        account_id: other_user.id, +        comment: ""        })      data = Map.put(activity.data, "content", "<script> alert('hecked :D:D:D:D:D:D:D') </script>") @@ -125,8 +125,8 @@ defmodule Pleroma.Web.AdminAPI.ReportViewTest do      {:ok, activity} =        CommonAPI.report(user, %{ -        "account_id" => other_user.id, -        "comment" => "" +        account_id: other_user.id, +        comment: ""        })      Pleroma.User.delete(other_user) diff --git a/test/web/common_api/common_api_test.exs b/test/web/common_api/common_api_test.exs index 1758662b0..c6ccc02c4 100644 --- a/test/web/common_api/common_api_test.exs +++ b/test/web/common_api/common_api_test.exs @@ -485,9 +485,9 @@ defmodule Pleroma.Web.CommonAPITest do        comment = "foobar"        report_data = %{ -        "account_id" => target_user.id, -        "comment" => comment, -        "status_ids" => [activity.id] +        account_id: target_user.id, +        comment: comment, +        status_ids: [activity.id]        }        note_obj = %{ @@ -517,9 +517,9 @@ defmodule Pleroma.Web.CommonAPITest do        {:ok, %Activity{id: report_id}} =          CommonAPI.report(reporter, %{ -          "account_id" => target_user.id, -          "comment" => "I feel offended", -          "status_ids" => [activity.id] +          account_id: target_user.id, +          comment: "I feel offended", +          status_ids: [activity.id]          })        {:ok, report} = CommonAPI.update_report_state(report_id, "resolved") @@ -538,9 +538,9 @@ defmodule Pleroma.Web.CommonAPITest do        {:ok, %Activity{id: report_id}} =          CommonAPI.report(reporter, %{ -          "account_id" => target_user.id, -          "comment" => "I feel offended", -          "status_ids" => [activity.id] +          account_id: target_user.id, +          comment: "I feel offended", +          status_ids: [activity.id]          })        assert CommonAPI.update_report_state(report_id, "test") == {:error, "Unsupported state"} @@ -552,16 +552,16 @@ defmodule Pleroma.Web.CommonAPITest do        {:ok, %Activity{id: first_report_id}} =          CommonAPI.report(reporter, %{ -          "account_id" => target_user.id, -          "comment" => "I feel offended", -          "status_ids" => [activity.id] +          account_id: target_user.id, +          comment: "I feel offended", +          status_ids: [activity.id]          })        {:ok, %Activity{id: second_report_id}} =          CommonAPI.report(reporter, %{ -          "account_id" => target_user.id, -          "comment" => "I feel very offended!", -          "status_ids" => [activity.id] +          account_id: target_user.id, +          comment: "I feel very offended!", +          status_ids: [activity.id]          })        {:ok, report_ids} = diff --git a/test/web/mastodon_api/controllers/report_controller_test.exs b/test/web/mastodon_api/controllers/report_controller_test.exs index 34ec8119e..21b037237 100644 --- a/test/web/mastodon_api/controllers/report_controller_test.exs +++ b/test/web/mastodon_api/controllers/report_controller_test.exs @@ -22,8 +22,9 @@ defmodule Pleroma.Web.MastodonAPI.ReportControllerTest do    test "submit a basic report", %{conn: conn, target_user: target_user} do      assert %{"action_taken" => false, "id" => _} =               conn +             |> put_req_header("content-type", "application/json")               |> post("/api/v1/reports", %{"account_id" => target_user.id}) -             |> json_response(200) +             |> json_response_and_validate_schema(200)    end    test "submit a report with statuses and comment", %{ @@ -33,23 +34,25 @@ defmodule Pleroma.Web.MastodonAPI.ReportControllerTest do    } do      assert %{"action_taken" => false, "id" => _} =               conn +             |> put_req_header("content-type", "application/json")               |> post("/api/v1/reports", %{                 "account_id" => target_user.id,                 "status_ids" => [activity.id],                 "comment" => "bad status!",                 "forward" => "false"               }) -             |> json_response(200) +             |> json_response_and_validate_schema(200)    end    test "account_id is required", %{      conn: conn,      activity: activity    } do -    assert %{"error" => "Valid `account_id` required"} = +    assert %{"error" => "Missing field: account_id."} =               conn +             |> put_req_header("content-type", "application/json")               |> post("/api/v1/reports", %{"status_ids" => [activity.id]}) -             |> json_response(400) +             |> json_response_and_validate_schema(400)    end    test "comment must be up to the size specified in the config", %{ @@ -63,17 +66,21 @@ defmodule Pleroma.Web.MastodonAPI.ReportControllerTest do      assert ^error =               conn +             |> put_req_header("content-type", "application/json")               |> post("/api/v1/reports", %{"account_id" => target_user.id, "comment" => comment}) -             |> json_response(400) +             |> json_response_and_validate_schema(400)    end    test "returns error when account is not exist", %{      conn: conn,      activity: activity    } do -    conn = post(conn, "/api/v1/reports", %{"status_ids" => [activity.id], "account_id" => "foo"}) +    conn = +      conn +      |> put_req_header("content-type", "application/json") +      |> post("/api/v1/reports", %{"status_ids" => [activity.id], "account_id" => "foo"}) -    assert json_response(conn, 400) == %{"error" => "Account not found"} +    assert json_response_and_validate_schema(conn, 400) == %{"error" => "Account not found"}    end    test "doesn't fail if an admin has no email", %{conn: conn, target_user: target_user} do @@ -81,7 +88,8 @@ defmodule Pleroma.Web.MastodonAPI.ReportControllerTest do      assert %{"action_taken" => false, "id" => _} =               conn +             |> put_req_header("content-type", "application/json")               |> post("/api/v1/reports", %{"account_id" => target_user.id}) -             |> json_response(200) +             |> json_response_and_validate_schema(200)    end  end  | 
