diff options
Diffstat (limited to 'test')
34 files changed, 320 insertions, 55 deletions
| diff --git a/test/formatter_test.exs b/test/formatter_test.exs index 2e717194b..f14077d25 100644 --- a/test/formatter_test.exs +++ b/test/formatter_test.exs @@ -197,7 +197,7 @@ defmodule Pleroma.FormatterTest do        {subs, text} = Formatter.add_user_links({[], text}, mentions) -      assert length(subs) == 0 +      assert Enum.empty?(subs)        Enum.each(subs, fn {uuid, _} -> assert String.contains?(text, uuid) end)        expected_text = "@a hi" diff --git a/test/media_proxy_test.exs b/test/media_proxy_test.exs index 05d927422..ddbadfbf5 100644 --- a/test/media_proxy_test.exs +++ b/test/media_proxy_test.exs @@ -140,6 +140,15 @@ defmodule Pleroma.MediaProxyTest do        assert String.starts_with?(encoded, Pleroma.Config.get([:media_proxy, :base_url]))      end + +    # https://git.pleroma.social/pleroma/pleroma/issues/580 +    test "encoding S3 links (must preserve `%2F`)" do +      url = +        "https://s3.amazonaws.com/example/test.png?X-Amz-Credential=your-access-key-id%2F20130721%2Fus-east-1%2Fs3%2Faws4_request" + +      encoded = url(url) +      assert decode_result(encoded) == url +    end    end    describe "when disabled" do diff --git a/test/notification_test.exs b/test/notification_test.exs index 94fb0ab15..755874a3d 100644 --- a/test/notification_test.exs +++ b/test/notification_test.exs @@ -6,7 +6,8 @@ defmodule Pleroma.NotificationTest do    use Pleroma.DataCase    alias Pleroma.Web.TwitterAPI.TwitterAPI    alias Pleroma.Web.CommonAPI -  alias Pleroma.{User, Notification} +  alias Pleroma.User +  alias Pleroma.Notification    alias Pleroma.Web.ActivityPub.Transmogrifier    import Pleroma.Factory @@ -299,7 +300,7 @@ defmodule Pleroma.NotificationTest do        {:ok, activity} = CommonAPI.post(user, %{"status" => "test post"}) -      assert length(Notification.for_user(user)) == 0 +      assert Enum.empty?(Notification.for_user(user))        {:ok, _, _} = CommonAPI.favorite(activity.id, other_user) @@ -307,7 +308,7 @@ defmodule Pleroma.NotificationTest do        {:ok, _} = CommonAPI.delete(activity.id, user) -      assert length(Notification.for_user(user)) == 0 +      assert Enum.empty?(Notification.for_user(user))      end      test "liking an activity results in 1 notification, then 0 if the activity is unliked" do @@ -316,7 +317,7 @@ defmodule Pleroma.NotificationTest do        {:ok, activity} = CommonAPI.post(user, %{"status" => "test post"}) -      assert length(Notification.for_user(user)) == 0 +      assert Enum.empty?(Notification.for_user(user))        {:ok, _, _} = CommonAPI.favorite(activity.id, other_user) @@ -324,7 +325,7 @@ defmodule Pleroma.NotificationTest do        {:ok, _, _, _} = CommonAPI.unfavorite(activity.id, other_user) -      assert length(Notification.for_user(user)) == 0 +      assert Enum.empty?(Notification.for_user(user))      end      test "repeating an activity results in 1 notification, then 0 if the activity is deleted" do @@ -333,7 +334,7 @@ defmodule Pleroma.NotificationTest do        {:ok, activity} = CommonAPI.post(user, %{"status" => "test post"}) -      assert length(Notification.for_user(user)) == 0 +      assert Enum.empty?(Notification.for_user(user))        {:ok, _, _} = CommonAPI.repeat(activity.id, other_user) @@ -341,7 +342,7 @@ defmodule Pleroma.NotificationTest do        {:ok, _} = CommonAPI.delete(activity.id, user) -      assert length(Notification.for_user(user)) == 0 +      assert Enum.empty?(Notification.for_user(user))      end      test "repeating an activity results in 1 notification, then 0 if the activity is unrepeated" do @@ -350,7 +351,7 @@ defmodule Pleroma.NotificationTest do        {:ok, activity} = CommonAPI.post(user, %{"status" => "test post"}) -      assert length(Notification.for_user(user)) == 0 +      assert Enum.empty?(Notification.for_user(user))        {:ok, _, _} = CommonAPI.repeat(activity.id, other_user) @@ -358,7 +359,7 @@ defmodule Pleroma.NotificationTest do        {:ok, _, _} = CommonAPI.unrepeat(activity.id, other_user) -      assert length(Notification.for_user(user)) == 0 +      assert Enum.empty?(Notification.for_user(user))      end      test "liking an activity which is already deleted does not generate a notification" do @@ -367,15 +368,15 @@ defmodule Pleroma.NotificationTest do        {:ok, activity} = CommonAPI.post(user, %{"status" => "test post"}) -      assert length(Notification.for_user(user)) == 0 +      assert Enum.empty?(Notification.for_user(user))        {:ok, _deletion_activity} = CommonAPI.delete(activity.id, user) -      assert length(Notification.for_user(user)) == 0 +      assert Enum.empty?(Notification.for_user(user))        {:error, _} = CommonAPI.favorite(activity.id, other_user) -      assert length(Notification.for_user(user)) == 0 +      assert Enum.empty?(Notification.for_user(user))      end      test "repeating an activity which is already deleted does not generate a notification" do @@ -384,15 +385,15 @@ defmodule Pleroma.NotificationTest do        {:ok, activity} = CommonAPI.post(user, %{"status" => "test post"}) -      assert length(Notification.for_user(user)) == 0 +      assert Enum.empty?(Notification.for_user(user))        {:ok, _deletion_activity} = CommonAPI.delete(activity.id, user) -      assert length(Notification.for_user(user)) == 0 +      assert Enum.empty?(Notification.for_user(user))        {:error, _} = CommonAPI.repeat(activity.id, other_user) -      assert length(Notification.for_user(user)) == 0 +      assert Enum.empty?(Notification.for_user(user))      end      test "replying to a deleted post without tagging does not generate a notification" do @@ -408,7 +409,7 @@ defmodule Pleroma.NotificationTest do            "in_reply_to_status_id" => activity.id          }) -      assert length(Notification.for_user(user)) == 0 +      assert Enum.empty?(Notification.for_user(user))      end    end  end diff --git a/test/object_test.exs b/test/object_test.exs index 72194975d..a820a34ee 100644 --- a/test/object_test.exs +++ b/test/object_test.exs @@ -5,7 +5,8 @@  defmodule Pleroma.ObjectTest do    use Pleroma.DataCase    import Pleroma.Factory -  alias Pleroma.{Repo, Object} +  alias Pleroma.Repo +  alias Pleroma.Object    test "returns an object by it's AP id" do      object = insert(:note) diff --git a/test/support/builders/user_builder.ex b/test/support/builders/user_builder.ex index 7a1ca79b5..611a5be18 100644 --- a/test/support/builders/user_builder.ex +++ b/test/support/builders/user_builder.ex @@ -1,5 +1,6 @@  defmodule Pleroma.Builders.UserBuilder do -  alias Pleroma.{User, Repo} +  alias Pleroma.User +  alias Pleroma.Repo    def build(data \\ %{}) do      user = %User{ diff --git a/test/tasks/relay_test.exs b/test/tasks/relay_test.exs index 96fac4811..64ff07753 100644 --- a/test/tasks/relay_test.exs +++ b/test/tasks/relay_test.exs @@ -4,7 +4,9 @@  defmodule Mix.Tasks.Pleroma.RelayTest do    alias Pleroma.Activity -  alias Pleroma.Web.ActivityPub.{ActivityPub, Relay, Utils} +  alias Pleroma.Web.ActivityPub.ActivityPub +  alias Pleroma.Web.ActivityPub.Utils +  alias Pleroma.Web.ActivityPub.Relay    alias Pleroma.User    use Pleroma.DataCase diff --git a/test/tasks/user_test.exs b/test/tasks/user_test.exs index 44271898c..7b814d171 100644 --- a/test/tasks/user_test.exs +++ b/test/tasks/user_test.exs @@ -151,7 +151,7 @@ defmodule Mix.Tasks.Pleroma.UserTest do        assert message =~ "Successfully unsubscribed"        user = User.get_by_nickname(user.nickname) -      assert length(user.following) == 0 +      assert Enum.empty?(user.following)        assert user.info.deactivated      end diff --git a/test/user_test.exs b/test/user_test.exs index 523ab1ea4..92991d063 100644 --- a/test/user_test.exs +++ b/test/user_test.exs @@ -4,7 +4,9 @@  defmodule Pleroma.UserTest do    alias Pleroma.Builders.UserBuilder -  alias Pleroma.{User, Repo, Activity} +  alias Pleroma.Activity +  alias Pleroma.Repo +  alias Pleroma.User    alias Pleroma.Web.CommonAPI    use Pleroma.DataCase @@ -55,18 +57,21 @@ defmodule Pleroma.UserTest do      followed_two = insert(:user)      blocked = insert(:user)      not_followed = insert(:user) +    reverse_blocked = insert(:user)      {:ok, user} = User.block(user, blocked) +    {:ok, reverse_blocked} = User.block(reverse_blocked, user)      {:ok, user} = User.follow(user, followed_zero) -    {:ok, user} = User.follow_all(user, [followed_one, followed_two, blocked]) +    {:ok, user} = User.follow_all(user, [followed_one, followed_two, blocked, reverse_blocked])      assert User.following?(user, followed_one)      assert User.following?(user, followed_two)      assert User.following?(user, followed_zero)      refute User.following?(user, not_followed)      refute User.following?(user, blocked) +    refute User.following?(user, reverse_blocked)    end    test "follow_all follows mutliple users without duplicating" do @@ -191,6 +196,26 @@ defmodule Pleroma.UserTest do        assert User.following?(registered_user, user)        refute User.following?(registered_user, remote_user) + +      Pleroma.Config.put([:instance, :autofollowed_nicknames], []) +    end + +    test "it sends a welcome message if it is set" do +      welcome_user = insert(:user) + +      Pleroma.Config.put([:instance, :welcome_user_nickname], welcome_user.nickname) +      Pleroma.Config.put([:instance, :welcome_message], "Hello, this is a cool site") + +      cng = User.register_changeset(%User{}, @full_user_data) +      {:ok, registered_user} = User.register(cng) + +      activity = Repo.one(Pleroma.Activity) +      assert registered_user.ap_id in activity.recipients +      assert activity.data["object"]["content"] =~ "cool site" +      assert activity.actor == welcome_user.ap_id + +      Pleroma.Config.put([:instance, :welcome_user_nickname], nil) +      Pleroma.Config.put([:instance, :welcome_message], nil)      end      test "it requires an email, name, nickname and password, bio is optional" do @@ -873,6 +898,16 @@ defmodule Pleroma.UserTest do          assert [] == User.search(query)        end)      end + +    test "works with URIs" do +      results = User.search("http://mastodon.example.org/users/admin", true) +      result = results |> List.first() + +      user = User.get_by_ap_id("http://mastodon.example.org/users/admin") + +      assert length(results) == 1 +      assert user == result |> Map.put(:search_rank, nil) +    end    end    test "auth_active?/1 works correctly" do diff --git a/test/web/activity_pub/activity_pub_controller_test.exs b/test/web/activity_pub/activity_pub_controller_test.exs index 570bee6b3..398bedf77 100644 --- a/test/web/activity_pub/activity_pub_controller_test.exs +++ b/test/web/activity_pub/activity_pub_controller_test.exs @@ -5,8 +5,13 @@  defmodule Pleroma.Web.ActivityPub.ActivityPubControllerTest do    use Pleroma.Web.ConnCase    import Pleroma.Factory -  alias Pleroma.Web.ActivityPub.{UserView, ObjectView} -  alias Pleroma.{Object, Repo, Activity, User, Instances} +  alias Pleroma.Web.ActivityPub.UserView +  alias Pleroma.Web.ActivityPub.ObjectView +  alias Pleroma.Object +  alias Pleroma.Repo +  alias Pleroma.Activity +  alias Pleroma.User +  alias Pleroma.Instances    setup_all do      Tesla.Mock.mock_global(fn env -> apply(HttpRequestMock, :request, [env]) end) @@ -397,7 +402,7 @@ defmodule Pleroma.Web.ActivityPub.ActivityPubControllerTest do          |> json_response(200)        assert result["first"]["orderedItems"] == [] -      assert result["totalItems"] == 1 +      assert result["totalItems"] == 0      end      test "it works for more than 10 users", %{conn: conn} do @@ -452,7 +457,7 @@ defmodule Pleroma.Web.ActivityPub.ActivityPubControllerTest do          |> json_response(200)        assert result["first"]["orderedItems"] == [] -      assert result["totalItems"] == 1 +      assert result["totalItems"] == 0      end      test "it works for more than 10 users", %{conn: conn} do diff --git a/test/web/activity_pub/activity_pub_test.exs b/test/web/activity_pub/activity_pub_test.exs index a55961ac4..a6f8b822a 100644 --- a/test/web/activity_pub/activity_pub_test.exs +++ b/test/web/activity_pub/activity_pub_test.exs @@ -7,7 +7,10 @@ defmodule Pleroma.Web.ActivityPub.ActivityPubTest do    alias Pleroma.Web.ActivityPub.ActivityPub    alias Pleroma.Web.ActivityPub.Utils    alias Pleroma.Web.CommonAPI -  alias Pleroma.{Activity, Object, User, Instances} +  alias Pleroma.Activity +  alias Pleroma.Object +  alias Pleroma.User +  alias Pleroma.Instances    alias Pleroma.Builders.ActivityBuilder    import Pleroma.Factory diff --git a/test/web/activity_pub/mrf/hellthread_policy_test.exs b/test/web/activity_pub/mrf/hellthread_policy_test.exs new file mode 100644 index 000000000..eb6ee4d04 --- /dev/null +++ b/test/web/activity_pub/mrf/hellthread_policy_test.exs @@ -0,0 +1,73 @@ +# Pleroma: A lightweight social networking server +# Copyright © 2019 Pleroma Authors <https://pleroma.social/> +# SPDX-License-Identifier: AGPL-3.0-only + +defmodule Pleroma.Web.ActivityPub.MRF.HellthreadPolicyTest do +  use Pleroma.DataCase +  import Pleroma.Factory + +  import Pleroma.Web.ActivityPub.MRF.HellthreadPolicy + +  setup do +    user = insert(:user) + +    message = %{ +      "actor" => user.ap_id, +      "cc" => [user.follower_address], +      "type" => "Create", +      "to" => [ +        "https://www.w3.org/ns/activitystreams#Public", +        "https://instance.tld/users/user1", +        "https://instance.tld/users/user2", +        "https://instance.tld/users/user3" +      ] +    } + +    [user: user, message: message] +  end + +  describe "reject" do +    test "rejects the message if the recipient count is above reject_threshold", %{ +      message: message +    } do +      Pleroma.Config.put([:mrf_hellthread], %{delist_threshold: 0, reject_threshold: 2}) + +      {:reject, nil} = filter(message) +    end + +    test "does not reject the message if the recipient count is below reject_threshold", %{ +      message: message +    } do +      Pleroma.Config.put([:mrf_hellthread], %{delist_threshold: 0, reject_threshold: 3}) + +      assert {:ok, ^message} = filter(message) +    end +  end + +  describe "delist" do +    test "delists the message if the recipient count is above delist_threshold", %{ +      user: user, +      message: message +    } do +      Pleroma.Config.put([:mrf_hellthread], %{delist_threshold: 2, reject_threshold: 0}) + +      {:ok, message} = filter(message) +      assert user.follower_address in message["to"] +      assert "https://www.w3.org/ns/activitystreams#Public" in message["cc"] +    end + +    test "does not delist the message if the recipient count is below delist_threshold", %{ +      message: message +    } do +      Pleroma.Config.put([:mrf_hellthread], %{delist_threshold: 4, reject_threshold: 0}) + +      assert {:ok, ^message} = filter(message) +    end +  end + +  test "excludes follower collection and public URI from threshold count", %{message: message} do +    Pleroma.Config.put([:mrf_hellthread], %{delist_threshold: 0, reject_threshold: 3}) + +    assert {:ok, ^message} = filter(message) +  end +end diff --git a/test/web/activity_pub/transmogrifier_test.exs b/test/web/activity_pub/transmogrifier_test.exs index e5e3c8d33..86c66deff 100644 --- a/test/web/activity_pub/transmogrifier_test.exs +++ b/test/web/activity_pub/transmogrifier_test.exs @@ -1128,4 +1128,58 @@ defmodule Pleroma.Web.ActivityPub.TransmogrifierTest do          )      end    end + +  describe "reserialization" do +    test "successfully reserializes a message with inReplyTo == nil" do +      user = insert(:user) + +      message = %{ +        "@context" => "https://www.w3.org/ns/activitystreams", +        "to" => ["https://www.w3.org/ns/activitystreams#Public"], +        "cc" => [], +        "type" => "Create", +        "object" => %{ +          "to" => ["https://www.w3.org/ns/activitystreams#Public"], +          "cc" => [], +          "type" => "Note", +          "content" => "Hi", +          "inReplyTo" => nil, +          "attributedTo" => user.ap_id +        }, +        "actor" => user.ap_id +      } + +      {:ok, activity} = Transmogrifier.handle_incoming(message) + +      {:ok, _} = Transmogrifier.prepare_outgoing(activity.data) +    end + +    test "successfully reserializes a message with AS2 objects in IR" do +      user = insert(:user) + +      message = %{ +        "@context" => "https://www.w3.org/ns/activitystreams", +        "to" => ["https://www.w3.org/ns/activitystreams#Public"], +        "cc" => [], +        "type" => "Create", +        "object" => %{ +          "to" => ["https://www.w3.org/ns/activitystreams#Public"], +          "cc" => [], +          "type" => "Note", +          "content" => "Hi", +          "inReplyTo" => nil, +          "attributedTo" => user.ap_id, +          "tag" => [ +            %{"name" => "#2hu", "href" => "http://example.com/2hu", "type" => "Hashtag"}, +            %{"name" => "Bob", "href" => "http://example.com/bob", "type" => "Mention"} +          ] +        }, +        "actor" => user.ap_id +      } + +      {:ok, activity} = Transmogrifier.handle_incoming(message) + +      {:ok, _} = Transmogrifier.prepare_outgoing(activity.data) +    end +  end  end diff --git a/test/web/activity_pub/views/user_view_test.exs b/test/web/activity_pub/views/user_view_test.exs index 7fc870e96..0bc1d4728 100644 --- a/test/web/activity_pub/views/user_view_test.exs +++ b/test/web/activity_pub/views/user_view_test.exs @@ -15,4 +15,43 @@ defmodule Pleroma.Web.ActivityPub.UserViewTest do      assert String.contains?(result["publicKey"]["publicKeyPem"], "BEGIN PUBLIC KEY")    end + +  describe "endpoints" do +    test "local users have a usable endpoints structure" do +      user = insert(:user) +      {:ok, user} = Pleroma.Web.WebFinger.ensure_keys_present(user) + +      result = UserView.render("user.json", %{user: user}) + +      assert result["id"] == user.ap_id + +      %{ +        "sharedInbox" => _, +        "oauthAuthorizationEndpoint" => _, +        "oauthRegistrationEndpoint" => _, +        "oauthTokenEndpoint" => _ +      } = result["endpoints"] +    end + +    test "remote users have an empty endpoints structure" do +      user = insert(:user, local: false) +      {:ok, user} = Pleroma.Web.WebFinger.ensure_keys_present(user) + +      result = UserView.render("user.json", %{user: user}) + +      assert result["id"] == user.ap_id +      assert result["endpoints"] == %{} +    end + +    test "instance users do not expose oAuth endpoints" do +      user = insert(:user, nickname: nil, local: true) +      {:ok, user} = Pleroma.Web.WebFinger.ensure_keys_present(user) + +      result = UserView.render("user.json", %{user: user}) + +      refute result["endpoints"]["oauthAuthorizationEndpoint"] +      refute result["endpoints"]["oauthRegistrationEndpoint"] +      refute result["endpoints"]["oauthTokenEndpoint"] +    end +  end  end diff --git a/test/web/admin_api/admin_api_controller_test.exs b/test/web/admin_api/admin_api_controller_test.exs index 42450a7b6..a27c26f95 100644 --- a/test/web/admin_api/admin_api_controller_test.exs +++ b/test/web/admin_api/admin_api_controller_test.exs @@ -5,7 +5,8 @@  defmodule Pleroma.Web.AdminAPI.AdminAPIControllerTest do    use Pleroma.Web.ConnCase -  alias Pleroma.{Repo, User} +  alias Pleroma.Repo +  alias Pleroma.User    import Pleroma.Factory    describe "/api/pleroma/admin/user" do diff --git a/test/web/common_api/common_api_test.exs b/test/web/common_api/common_api_test.exs index d26b6e49c..870648fb5 100644 --- a/test/web/common_api/common_api_test.exs +++ b/test/web/common_api/common_api_test.exs @@ -2,7 +2,7 @@  # Copyright © 2017-2019 Pleroma Authors <https://pleroma.social/>  # SPDX-License-Identifier: AGPL-3.0-only -defmodule Pleroma.Web.CommonAPI.Test do +defmodule Pleroma.Web.CommonAPITest do    use Pleroma.DataCase    alias Pleroma.Web.CommonAPI    alias Pleroma.User diff --git a/test/web/common_api/common_api_utils_test.exs b/test/web/common_api/common_api_utils_test.exs index 754bc7255..faed6b685 100644 --- a/test/web/common_api/common_api_utils_test.exs +++ b/test/web/common_api/common_api_utils_test.exs @@ -5,7 +5,7 @@  defmodule Pleroma.Web.CommonAPI.UtilsTest do    alias Pleroma.Web.CommonAPI.Utils    alias Pleroma.Web.Endpoint -  alias Pleroma.Builders.{UserBuilder} +  alias Pleroma.Builders.UserBuilder    use Pleroma.DataCase    test "it adds attachment links to a given text and attachment set" do diff --git a/test/web/federator_test.exs b/test/web/federator_test.exs index 05f813291..9f8d71454 100644 --- a/test/web/federator_test.exs +++ b/test/web/federator_test.exs @@ -3,7 +3,8 @@  # SPDX-License-Identifier: AGPL-3.0-only  defmodule Pleroma.Web.FederatorTest do -  alias Pleroma.Web.{CommonAPI, Federator} +  alias Pleroma.Web.CommonAPI +  alias Pleroma.Web.Federator    alias Pleroma.Instances    use Pleroma.DataCase    import Pleroma.Factory diff --git a/test/web/mastodon_api/mastodon_api_controller_test.exs b/test/web/mastodon_api/mastodon_api_controller_test.exs index 1a60ad8e6..26c9c25a6 100644 --- a/test/web/mastodon_api/mastodon_api_controller_test.exs +++ b/test/web/mastodon_api/mastodon_api_controller_test.exs @@ -6,8 +6,13 @@ defmodule Pleroma.Web.MastodonAPI.MastodonAPIControllerTest do    use Pleroma.Web.ConnCase    alias Pleroma.Web.TwitterAPI.TwitterAPI -  alias Pleroma.{Repo, User, Object, Activity, Notification} -  alias Pleroma.Web.{OStatus, CommonAPI} +  alias Pleroma.Repo +  alias Pleroma.User +  alias Pleroma.Object +  alias Pleroma.Activity +  alias Pleroma.Notification +  alias Pleroma.Web.OStatus +  alias Pleroma.Web.CommonAPI    alias Pleroma.Web.ActivityPub.ActivityPub    alias Pleroma.Web.MastodonAPI.FilterView    alias Ecto.Changeset @@ -31,7 +36,7 @@ defmodule Pleroma.Web.MastodonAPI.MastodonAPIControllerTest do        |> assign(:user, user)        |> get("/api/v1/timelines/home") -    assert length(json_response(conn, 200)) == 0 +    assert Enum.empty?(json_response(conn, 200))      {:ok, user} = User.follow(user, following) diff --git a/test/web/mastodon_api/status_view_test.exs b/test/web/mastodon_api/status_view_test.exs index 2106253f2..0dc9c538c 100644 --- a/test/web/mastodon_api/status_view_test.exs +++ b/test/web/mastodon_api/status_view_test.exs @@ -5,7 +5,8 @@  defmodule Pleroma.Web.MastodonAPI.StatusViewTest do    use Pleroma.DataCase -  alias Pleroma.Web.MastodonAPI.{StatusView, AccountView} +  alias Pleroma.Web.MastodonAPI.AccountView +  alias Pleroma.Web.MastodonAPI.StatusView    alias Pleroma.User    alias Pleroma.Web.OStatus    alias Pleroma.Web.CommonAPI diff --git a/test/web/oauth/authorization_test.exs b/test/web/oauth/authorization_test.exs index 3b1ddada8..81618e935 100644 --- a/test/web/oauth/authorization_test.exs +++ b/test/web/oauth/authorization_test.exs @@ -4,7 +4,8 @@  defmodule Pleroma.Web.OAuth.AuthorizationTest do    use Pleroma.DataCase -  alias Pleroma.Web.OAuth.{Authorization, App} +  alias Pleroma.Web.OAuth.Authorization +  alias Pleroma.Web.OAuth.App    import Pleroma.Factory    test "create an authorization token for a valid app" do diff --git a/test/web/oauth/oauth_controller_test.exs b/test/web/oauth/oauth_controller_test.exs index e0d3cb55f..2315f9a34 100644 --- a/test/web/oauth/oauth_controller_test.exs +++ b/test/web/oauth/oauth_controller_test.exs @@ -7,7 +7,8 @@ defmodule Pleroma.Web.OAuth.OAuthControllerTest do    import Pleroma.Factory    alias Pleroma.Repo -  alias Pleroma.Web.OAuth.{Authorization, Token} +  alias Pleroma.Web.OAuth.Authorization +  alias Pleroma.Web.OAuth.Token    test "redirects with oauth authorization" do      user = insert(:user) diff --git a/test/web/oauth/token_test.exs b/test/web/oauth/token_test.exs index 9a241d61a..4dab4a308 100644 --- a/test/web/oauth/token_test.exs +++ b/test/web/oauth/token_test.exs @@ -4,7 +4,9 @@  defmodule Pleroma.Web.OAuth.TokenTest do    use Pleroma.DataCase -  alias Pleroma.Web.OAuth.{App, Token, Authorization} +  alias Pleroma.Web.OAuth.App +  alias Pleroma.Web.OAuth.Authorization +  alias Pleroma.Web.OAuth.Token    alias Pleroma.Repo    import Pleroma.Factory diff --git a/test/web/ostatus/activity_representer_test.exs b/test/web/ostatus/activity_representer_test.exs index 0869f2fd5..eebc5c040 100644 --- a/test/web/ostatus/activity_representer_test.exs +++ b/test/web/ostatus/activity_representer_test.exs @@ -6,7 +6,9 @@ defmodule Pleroma.Web.OStatus.ActivityRepresenterTest do    use Pleroma.DataCase    alias Pleroma.Web.OStatus.ActivityRepresenter -  alias Pleroma.{User, Activity, Object} +  alias Pleroma.Activity +  alias Pleroma.User +  alias Pleroma.Object    alias Pleroma.Web.ActivityPub.ActivityPub    alias Pleroma.Web.OStatus diff --git a/test/web/ostatus/feed_representer_test.exs b/test/web/ostatus/feed_representer_test.exs index 55717dec7..efd4e7217 100644 --- a/test/web/ostatus/feed_representer_test.exs +++ b/test/web/ostatus/feed_representer_test.exs @@ -6,7 +6,9 @@ defmodule Pleroma.Web.OStatus.FeedRepresenterTest do    use Pleroma.DataCase    import Pleroma.Factory    alias Pleroma.User -  alias Pleroma.Web.OStatus.{FeedRepresenter, UserRepresenter, ActivityRepresenter} +  alias Pleroma.Web.OStatus.ActivityRepresenter +  alias Pleroma.Web.OStatus.FeedRepresenter +  alias Pleroma.Web.OStatus.UserRepresenter    alias Pleroma.Web.OStatus    test "returns a feed of the last 20 items of the user" do diff --git a/test/web/ostatus/incoming_documents/delete_handling_test.exs b/test/web/ostatus/incoming_documents/delete_handling_test.exs index d97cd79f4..d295cc539 100644 --- a/test/web/ostatus/incoming_documents/delete_handling_test.exs +++ b/test/web/ostatus/incoming_documents/delete_handling_test.exs @@ -4,7 +4,9 @@ defmodule Pleroma.Web.OStatus.DeleteHandlingTest do    import Pleroma.Factory    import Tesla.Mock -  alias Pleroma.{Repo, Activity, Object} +  alias Pleroma.Repo +  alias Pleroma.Activity +  alias Pleroma.Object    alias Pleroma.Web.OStatus    setup do diff --git a/test/web/ostatus/ostatus_controller_test.exs b/test/web/ostatus/ostatus_controller_test.exs index 3145ca9a1..da9c72be8 100644 --- a/test/web/ostatus/ostatus_controller_test.exs +++ b/test/web/ostatus/ostatus_controller_test.exs @@ -5,7 +5,9 @@  defmodule Pleroma.Web.OStatus.OStatusControllerTest do    use Pleroma.Web.ConnCase    import Pleroma.Factory -  alias Pleroma.{User, Repo, Object} +  alias Pleroma.User +  alias Pleroma.Repo +  alias Pleroma.Object    alias Pleroma.Web.CommonAPI    alias Pleroma.Web.OStatus.ActivityRepresenter diff --git a/test/web/ostatus/ostatus_test.exs b/test/web/ostatus/ostatus_test.exs index dbe5de2e2..b4b19ab05 100644 --- a/test/web/ostatus/ostatus_test.exs +++ b/test/web/ostatus/ostatus_test.exs @@ -6,7 +6,11 @@ defmodule Pleroma.Web.OStatusTest do    use Pleroma.DataCase    alias Pleroma.Web.OStatus    alias Pleroma.Web.XML -  alias Pleroma.{Object, Repo, User, Activity, Instances} +  alias Pleroma.Object +  alias Pleroma.Repo +  alias Pleroma.User +  alias Pleroma.Activity +  alias Pleroma.Instances    import Pleroma.Factory    import ExUnit.CaptureLog diff --git a/test/web/salmon/salmon_test.exs b/test/web/salmon/salmon_test.exs index c539a28b2..9e583ba40 100644 --- a/test/web/salmon/salmon_test.exs +++ b/test/web/salmon/salmon_test.exs @@ -5,7 +5,9 @@  defmodule Pleroma.Web.Salmon.SalmonTest do    use Pleroma.DataCase    alias Pleroma.Web.Salmon -  alias Pleroma.{Repo, Activity, User} +  alias Pleroma.Activity +  alias Pleroma.Repo +  alias Pleroma.User    import Pleroma.Factory    @magickey "RSA.pu0s-halox4tu7wmES1FVSx6u-4wc0YrUFXcqWXZG4-27UmbCOpMQftRCldNRfyA-qLbz-eqiwQhh-1EwUvjsD4cYbAHNGHwTvDOyx5AKthQUP44ykPv7kjKGh3DWKySJvcs9tlUG87hlo7AvnMo9pwRS_Zz2CacQ-MKaXyDepk=.AQAB" diff --git a/test/web/twitter_api/representers/activity_representer_test.exs b/test/web/twitter_api/representers/activity_representer_test.exs index ea5813733..365c7f659 100644 --- a/test/web/twitter_api/representers/activity_representer_test.exs +++ b/test/web/twitter_api/representers/activity_representer_test.exs @@ -4,8 +4,11 @@  defmodule Pleroma.Web.TwitterAPI.Representers.ActivityRepresenterTest do    use Pleroma.DataCase -  alias Pleroma.{User, Activity, Object} -  alias Pleroma.Web.TwitterAPI.Representers.{ActivityRepresenter, ObjectRepresenter} +  alias Pleroma.User +  alias Pleroma.Activity +  alias Pleroma.Object +  alias Pleroma.Web.TwitterAPI.Representers.ActivityRepresenter +  alias Pleroma.Web.TwitterAPI.Representers.ObjectRepresenter    alias Pleroma.Web.ActivityPub.ActivityPub    alias Pleroma.Web.TwitterAPI.UserView    import Pleroma.Factory diff --git a/test/web/twitter_api/twitter_api_controller_test.exs b/test/web/twitter_api/twitter_api_controller_test.exs index 855ae1526..acb03b146 100644 --- a/test/web/twitter_api/twitter_api_controller_test.exs +++ b/test/web/twitter_api/twitter_api_controller_test.exs @@ -5,8 +5,13 @@  defmodule Pleroma.Web.TwitterAPI.ControllerTest do    use Pleroma.Web.ConnCase    alias Pleroma.Web.TwitterAPI.Representers.ActivityRepresenter -  alias Pleroma.Builders.{ActivityBuilder, UserBuilder} -  alias Pleroma.{Repo, Activity, User, Object, Notification} +  alias Pleroma.Builders.ActivityBuilder +  alias Pleroma.Builders.UserBuilder +  alias Pleroma.Repo +  alias Pleroma.Activity +  alias Pleroma.User +  alias Pleroma.Object +  alias Pleroma.Notification    alias Pleroma.Web.ActivityPub.ActivityPub    alias Pleroma.Web.TwitterAPI.UserView    alias Pleroma.Web.TwitterAPI.NotificationView diff --git a/test/web/twitter_api/twitter_api_test.exs b/test/web/twitter_api/twitter_api_test.exs index 48ddbcf50..aa2a4d650 100644 --- a/test/web/twitter_api/twitter_api_test.exs +++ b/test/web/twitter_api/twitter_api_test.exs @@ -4,8 +4,13 @@  defmodule Pleroma.Web.TwitterAPI.TwitterAPITest do    use Pleroma.DataCase -  alias Pleroma.Web.TwitterAPI.{TwitterAPI, UserView} -  alias Pleroma.{Activity, User, Object, Repo, UserInviteToken} +  alias Pleroma.Web.TwitterAPI.TwitterAPI +  alias Pleroma.Web.TwitterAPI.UserView +  alias Pleroma.Activity +  alias Pleroma.User +  alias Pleroma.Object +  alias Pleroma.Repo +  alias Pleroma.UserInviteToken    alias Pleroma.Web.ActivityPub.ActivityPub    alias Pleroma.Web.TwitterAPI.ActivityView diff --git a/test/web/twitter_api/views/notification_view_test.exs b/test/web/twitter_api/views/notification_view_test.exs index 8367fc6c7..3a67f7292 100644 --- a/test/web/twitter_api/views/notification_view_test.exs +++ b/test/web/twitter_api/views/notification_view_test.exs @@ -5,7 +5,8 @@  defmodule Pleroma.Web.TwitterAPI.NotificationViewTest do    use Pleroma.DataCase -  alias Pleroma.{User, Notification} +  alias Pleroma.User +  alias Pleroma.Notification    alias Pleroma.Web.TwitterAPI.TwitterAPI    alias Pleroma.Web.TwitterAPI.NotificationView    alias Pleroma.Web.TwitterAPI.UserView diff --git a/test/web/websub/websub_controller_test.exs b/test/web/websub/websub_controller_test.exs index 6492df2a0..87b01d89b 100644 --- a/test/web/websub/websub_controller_test.exs +++ b/test/web/websub/websub_controller_test.exs @@ -6,7 +6,8 @@ defmodule Pleroma.Web.Websub.WebsubControllerTest do    use Pleroma.Web.ConnCase    import Pleroma.Factory    alias Pleroma.Web.Websub.WebsubClientSubscription -  alias Pleroma.{Repo, Activity} +  alias Pleroma.Activity +  alias Pleroma.Repo    alias Pleroma.Web.Websub    test "websub subscription request", %{conn: conn} do @@ -80,7 +81,7 @@ defmodule Pleroma.Web.Websub.WebsubControllerTest do        assert response(conn, 500) == "Error" -      assert length(Repo.all(Activity)) == 0 +      assert Enum.empty?(Repo.all(Activity))      end    end  end diff --git a/test/web/websub/websub_test.exs b/test/web/websub/websub_test.exs index 9751d161d..9a9b9df02 100644 --- a/test/web/websub/websub_test.exs +++ b/test/web/websub/websub_test.exs @@ -5,7 +5,8 @@  defmodule Pleroma.Web.WebsubTest do    use Pleroma.DataCase    alias Pleroma.Web.Websub -  alias Pleroma.Web.Websub.{WebsubServerSubscription, WebsubClientSubscription} +  alias Pleroma.Web.Websub.WebsubServerSubscription +  alias Pleroma.Web.Websub.WebsubClientSubscription    import Pleroma.Factory    alias Pleroma.Web.Router.Helpers    import Tesla.Mock | 
