summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-07-05Improve tests after code reviewIlja
2022-07-02Rename pipelines and add forgotten tagsIlja
I renamed some tags before, but forgot to rename the pipelines I also had some tags which I forgot to add to the config, description, etc. These have now been done/added
2022-07-02Add better explanation in the Cheatsheet about what each tag doesIlja
2022-07-02Change order of privilege tags to make more senseIlja
The tags were listed in different places They were listed in a rather randomly order I reordered them in a way I think makes more sense
2022-07-02Fix typo'sIlja
priviledge |-> privilege
2022-07-01Add docs and CHANGELOG entriesIlja
2022-07-01Rename privilege tagsIlja
I first focussed on getting things working Now that they do and we know what tags there are, I put some thought in providing better names I use the form <what_it_controls>_<what_it_allows_you_to_do> :statuses_read => :messages_read :status_delete => :messages_delete :user_read => :users_read :user_deletion => :users_delete :user_activation => :users_manage_activation_state :user_invite => :users_manage_invites :user_tag => :users_manage_tags :user_credentials => :users_manage_credentials :report_handle => :reports_manage_reports :emoji_management => :emoji_manage_emoji
2022-06-21Add nodes and privileges to nodeinfoIlja
I didn't add it to /api/v1/instance I was wondering if I should, but since it e.g. also didn't show staff, it felt better not to
2022-06-21Show privileges to FEIlja
I added an extra key We already had is_admin and is_moderator, now we have an extra privileges key
2022-06-21Add deactivated status for privileged usersIlja
Deactivated users are only visible to users privileged with :user_activation since fc317f3b17 Here we also make sure the users who are deactivated get the status deactivated for users who are allowed to see these users
2022-06-21report notifications for privileged usersIlja
Instead of `Pleroma.User.all_superusers()` we now use `Pleroma.User.all_superusers(:report_handle)` I also changed it for sending emails, but there were no tests.
2022-06-21Add Pleroma.User.all_users_with_privilege/1Ilja
This should eventually replace the Pleroma.User.all_superusers/0 function * I added a new param `is_privileged` in User.query * Now we can fetch all users with a specified privilege
2022-06-21Remove function superuser?Ilja
Everything now happens with privileged?/2
2022-06-21Hide pleroma:report for non-privileged usersIlja
Before we deleted the notifications, but that was a side effect and didn't always trigger any more. Now we just hide them when an unprivileged user asks them.
2022-06-21Revert "Delete report notifs when demoting from superuser"Ilja
This reverts commit 89667189b840fc79d85336739e6b2512684d7be0 and cdc5bbe8369d4fc66d642bb3e845a237d11e34d7. This is a side effect when changing user role. The goal was to not have report notifications when someone isn't admin or moderator any more. But this won't be triggered when we change the privilege tags for a role, so we can't use this sollution any more. There was another solution to filter out report notifications during fetch. It wasn't merged because this seemed 'cleaner' at the time, but now it seems the better sollution. I'll add it in the next commit.
2022-06-21User.visible_for/2Ilja
According to the tests, this was only used for unconfirmed accounts. So this just needed to be restricted to users with privilege :user_activation
2022-06-21Validator for deleting statusses is now done with priviledge instead of ↵Ilja
superuser
2022-06-21delete statusses is now privileged by :status_deleteIlja
Instead of superusers, you now need a role with privilige :status_delete to delete other users statusses I also cleaned up some other stuff I saw
2022-06-21Add Pleroma.User.privileged?/2Ilja
This should eventually replace Pleroma.User.superuser?/1
2022-06-21Fix warning during test user_test.exsIlja
Fixed the warning [warning] Please change `clear_config([section], key: value)` to `clear_config([section, key], value)`
2022-06-21Add last priviligesIlja
I still had three endpoints I didn't really know what to do with them. I added them under separate tags * :instance_delete * :moderation_log_read * :stats_read I also checked and these are the last changes done by MR https://git.pleroma.social/pleroma/pleroma/-/merge_requests/3480/diffs this is trying to fix
2022-06-21Add privilige :emoji_managementIlja
2022-06-21Add privilige :status_deleteIlja
It also allows to update a message, so it's not just deleting. I need a better name...
2022-06-21last off :statuses_readIlja
From the endpoints left to do, I believe these should be under :statuses_read. These should be the last for that privilege for this MR
2022-06-21Mark relevant tests synchronousIlja
One of the things we do during the tests is change the config. But that's global state and different tests were interfering. E.g. one test would set `clear_config([:instance, :admin_privileges], [:statuses_read])`, but while that runs, another test may do `clear_config([:instance, :admin_privileges], [:user_invite])`. Now the code for the first test checks the setting, and it finds `:user_invite` instead of `:statuses_read`. Now the modules where this happens are marked to run synchronously, so they don't interfere with each other.
2022-06-21Add privileges for :user_readIlja
2022-06-21Add privileges for :report_handleIlja
2022-06-21Add privileges for :user_inviteIlja
2022-06-21Add privileges for :user_activationIlja
2022-06-21Add privileges for :user_tagIlja
2022-06-21Remove privileged_staffIlja
Everything that was done through this setting, can now be set by giving the proper privileges to the roles.
2022-06-21Add priviledges for :statuses_readIlja
This was the last in :require_privileged_staff. I'll remove that in the next commit
2022-06-21Add priviledges for :user_credentialsIlja
I only moved the ones from the :require_privileged_staff block for now
2022-06-21Add privilege :user_deletionIlja
2022-06-21Add new setting and Plug to allow for privilege settings for staffIlja
2022-05-22Merge branch 'lewdthewides-develop-patch-48691' into 'develop'Haelwenn
Instruct users to run 'git pull' as the pleroma user See merge request pleroma/pleroma!3667
2022-05-19Merge branch 'fix/mrf-steal-emoji-regex' into 'develop'lain
StealEmojiPolicy: fix String rejected_shortcodes See merge request pleroma/pleroma!3673
2022-05-18StealEmojiPolicy: fix String rejected_shortcodesHélène
* rejected_shortcodes is defined as a list of strings in the configuration description. As such, database-based configuration was led to handle those settings as strings, and not as the actually expected type, Regex. * This caused each message passing through this MRF, if a rejected shortcode was set and the emoji did not exist already on the instance, to fail federating, as an exception was raised, swiftly caught and mostly silenced. * This commit fixes the issue by introducing new behavior: strings are now handled as perfect matches for an emoji shortcode (meaning that if the emoji-to-be-pulled's shortcode is in the blacklist, it will be rejected), while still supporting Regex types as before.
2022-05-12Instruct users to run 'git pull' as the pleroma userlewdthewides
2022-05-08Merge branch 'improve_anti_followbot_policy' into 'develop'Haelwenn
Also use actor_type to determine if an account is a bot in antiFollowbotPolicy Closes #2561 See merge request pleroma/pleroma!3498
2022-05-08Also use actor_type to determine if an account is a bot in antiFollowbotPolicyIlja
2022-05-06Merge branch 'security/2.4.3-develop' into 'develop'Haelwenn
Merge back 2.4.3 See merge request pleroma/pleroma!3663
2022-05-06mix: Bump to 2.4.52 for 2.4.3 mergebackHaelwenn (lanodan) Monnier
2022-05-06Skip cache when /objects or /activities is authenticatedTusooa Zhu
Ref: fix-local-public
2022-05-06Allow to skip cache in Cache plugTusooa Zhu
Ref: fix-local-public
2022-05-06update sweet_xml [Security]Ilja
2022-04-18Merge branch 'from/upstream-develop/tusooa/fix-en-fallback' into 'develop'Haelwenn
Fix incorrect fallback when English is set to first language See merge request pleroma/pleroma!3656
2022-04-17Fix incorrect fallback when English is set to first languageTusooa Zhu
2022-04-05Merge branch 'fix_eratic_test_for_report_notes' into 'develop'Haelwenn
Fix eratic test for POST /api/pleroma/admin/reports/:id/notes See merge request pleroma/pleroma!3653
2022-04-05Fix eratic test for POST /api/pleroma/admin/reports/:id/notesIlja
It retrieved two ReportNotes and then checked one of them. But the order isn't guaranteed, while the test tested on the content of the first ReportNote. I made the test on the content more generic