| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
|
|
Without a valid inbox we can't generate the publish_one Oban jobs
|
|
Before splitting the publish_one/1 function into two parts for testing purposes we had logic that checked the keys of params for :unreachable_since and if it was absent it did not set the instance as reachable. There is also a test to validate that when unreachable_since is nil, we set it as reachable.
However the default value of :unreachable_since when an instance is reachable is nil. The test appears to be testing a scenario that does not exist in the real world, and with this refactor we will always have an :unreachable_since key.
We were attempting to update the reachability upon every successful federation because we always include it when we generate the publish_one jobs.
|
|
|
|
|
|
Support `id` param in `GET /api/v1/statuses`
See merge request pleroma/pleroma!4204
|
|
Signed-off-by: marcin mikołajczak <git@mkljczk.pl>
|
|
Gun: Publisher job behavior improvement
See merge request pleroma/pleroma!4202
|
|
Gun's connection pool also returns an error if duplicate workers are launched simultaneously. Snooze on this error as well, and lower the snooze to 3 seconds with the optimism that the connection will still be open by then and the delivery can be completed quickly.
The original setting of 30 seconds is pretty high and means there's an unnatural lag between deliveries of activities destined to the same server that were created at nearly the same time. This configuration should be more efficient.
|
|
Stable
See merge request pleroma/pleroma!4201
|
|
v2.7.0
See merge request pleroma/pleroma!4179
|
|
|
|
|
|
|
|
Fix User.disclose_client never working correctly
See merge request pleroma/pleroma!4199
|
|
Our test environment cheats by constructing a conn with a custom oauth_access/2 function. This assigns a :token to the conn but due to the way it is constructed it has the :user preloaded. When the OAuth Plug fetches a token it does not preload the user, so the check for user.disclose_client was always nil and assumed to be false.
Preloading the :user ensures the test environment matches reality.
|
|
Fix publisher job migration error
See merge request pleroma/pleroma!4198
|
|
|
|
Align Hackney and Gun connection pool timeouts
See merge request pleroma/pleroma!4197
|
|
Increase federator outgoing job parallelism
See merge request pleroma/pleroma!4196
|
|
Publisher job simplification
See merge request pleroma/pleroma!4194
|
|
|
|
|
|
We can use Pleroma.Repo to fetch the jobs
|
|
Remove unused Oban queue
See merge request pleroma/pleroma!4195
|
|
|
|
The old jobs remain and will fail gracefully
|
|
Backups Refactoring
See merge request pleroma/pleroma!4158
|
|
|
|
|
|
|
|
Publisher jobs now store the the activity id instead of inserting duplicate JSON data in the Oban queue for each delivery.
|
|
Fix Optimistic Inbox for failed signatures
See merge request pleroma/pleroma!4193
|
|
It is angry we are making a fake %Plug.Conn{} to pass through Signature.validate_signature/1. We can work around it by making the code support a map, but then we lose the benefit of being able to use put_req_header/3
|
|
|
|
|
|
|
|
|
|
This logic only exists in the Plug, so attempting to validate the signature by calling the library function HTTPSignature.validate_conn/2 directly will never work because we do not attempt to construct the (request-target) and @request-target headers with both the commonly misinterpreted and correct implementation of this field. Therefore all attempts to validate a signature from an Oban Job will fail.
|
|
When signatures fail on incoming activities we put the job into Oban to be processed later instead of doing the user fetching and validation inline which is expensive and increases latency on the incoming POST request. Unfortunately we did not retain the :method, :request_path, and :query_string parameters from the conn so the signature validation and Oban Job would always fail.
This was most obvious when Mastodon sends Deletes for users your server has never seen before.
|
|
Harden Rich Media parsing against very slow or malicious URLs
See merge request pleroma/pleroma!4192
|
|
|
|
|
|
|
|
The negative cache entry was a nil value, but that is an expected response when the cache is missing an entry so it didn't work as intended.
|
|
negative cache entry
This is for a normal HTTP error response or timeout while receiving the data. A hard error from a process crash, DNS lookup failure, etc should produce a different response than {:ok, %Tesla.Env{}} and the request/job will be retryable.
|
