summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-05-07CredoMark Felder
2024-05-07Fix compile warningMark Felder
warning: "else" clauses will never match because all patterns in "with" will always match lib/pleroma/web/rich_media/parser/ttl/opengraph.ex:10
2024-05-08Mastodon API: Remove deprecated GET /api/v1/statuses/:id/card endpointMark Felder
Removed back in 2019 https://github.com/mastodon/mastodon/pull/11213
2024-05-08Remove test validating missing descriptions are returned as an empty stringMark Felder
2024-05-08Improve test descriptionMark Felder
2024-05-08Rich Media Cards are fetched asynchonously and not guaranteed to be ↵Mark Felder
available on first post render
2024-05-08Rich Media Cards are cached by URL not per statusMark Felder
2024-05-07Fix broken Rich Media parsing when the image URL is a relative pathMark Felder
2024-05-07Respect the TTL returned in OpenGraph tagsMark Felder
2024-05-07Fix broken testsMark Felder
2024-05-07Increase the :max_body for Rich Media to 5MBMark Felder
Websites are increasingly getting more bloated with tricks like inlining content (e.g., CNN.com) which puts pages at or above 5MB. This value may still be too low.
2024-05-07RichMedia refactorMark Felder
Rich Media parsing was previously handled on-demand with a 2 second HTTP request timeout and retained only in Cachex. Every time a Pleroma instance is restarted it will have to request and parse the data for each status with a URL detected. When fetching a batch of statuses they were processed in parallel to attempt to keep the maximum latency at 2 seconds, but often resulted in a timeline appearing to hang during loading due to a URL that could not be successfully reached. URLs which had images links that expire (Amazon AWS) were parsed and inserted with a TTL to ensure the image link would not break. Rich Media data is now cached in the database and fetched asynchronously. Cachex is used as a read-through cache. When the data becomes available we stream an update to the clients. If the result is returned quickly the experience is almost seamless. Activities were already processed for their Rich Media data during ingestion to warm the cache, so users should not normally encounter the asynchronous loading of the Rich Media data. Implementation notes: - The async worker is a Task with a globally unique process name to prevent duplicate processing of the same URL - The Task will attempt to fetch the data 3 times with increasing sleep time between attempts - The HTTP request obeys the default HTTP request timeout value instead of 2 seconds - URLs that cannot be successfully parsed due to an unexpected error receives a negative cache entry for 15 minutes - URLs that fail with an expected error will receive a negative cache with no TTL - Activities that have no detected URLs insert a nil value in the Cachex :scrubber_cache so we do not repeat parsing the object content with Floki every time the activity is rendered - Expiring image URLs are handled with an Oban job - There is no automatic cleanup of the Rich Media data in the database, but it is safe to delete at any time - The post draft/preview feature makes the URL processing synchronous so the rendered post preview will have an accurate rendering Overall performance of timelines and creating new posts which contain URLs is greatly improved.
2024-05-07Merge branch 'revert-50af909c' into 'develop'feld
Revert "Merge branch 'pleroma-card-image-description' into 'develop'" See merge request pleroma/pleroma!4107
2024-05-07Revert "Merge branch 'pleroma-card-image-description' into 'develop'"feld
This reverts merge request !4101
2024-05-07Update changelog entryMark Felder
2024-05-07Add the absent max_featured_tags to the api spec for /api/v1/instanceMark Felder
2024-05-07Add configuration[accounts][max_pinned_statuses] to /api/v2/instanceMark Felder
Also add the absent max_featured_tags to the api spec for /api/v2/instance
2024-05-07Add configuration[statuses][characters_reserved_per_url] to /api/v2/instanceMark Felder
Fixes #3250
2024-05-07Strip actor from objects before federatingMark Felder
2024-05-07Merge branch 'description-type' into 'develop'lain
Fix type in config description See merge request pleroma/pleroma!4104
2024-04-27Fix type in descriptionmarcin mikołajczak
Signed-off-by: marcin mikołajczak <git@mkljczk.pl>
2024-04-25Apply @lanodan's suggestionHaelwenn
Signed-off-by: marcin mikołajczak <git@mkljczk.pl>
2024-04-19Merge branch 'pleroma-card-image-description' into 'develop'lain
Include image description in status media cards See merge request pleroma/pleroma!4101
2024-04-19Include image description in status media cardsmarcin mikołajczak
Signed-off-by: marcin mikołajczak <git@mkljczk.pl>
2024-04-19Merge branch 'receiverworker-error-handling' into 'develop'lain
ReceiverWorker: Make sure non-{:ok, _} is returned as {:error, …} See merge request pleroma/pleroma!4100
2024-04-17Merge branch 'ffmpeg-limiter' into 'develop'Haelwenn
Prevent Media Helper from respawning ffmpeg for bad media See merge request pleroma/pleroma!4086
2024-04-17ReceiverWorker: Make sure non-{:ok, _} is returned as {:error, …}Haelwenn (lanodan) Monnier
Otherwise an error like `{:signature, {:error, {:error, :not_found}}}` ends up considered a success.
2024-04-12Merge branch 'user-actor-webfinger' into 'develop'tusooa
FEP-2c59, add "webfinger" to user actor See merge request pleroma/pleroma!4099
2024-04-11FEP-2c59, add "webfinger" to user actormarcin mikołajczak
Signed-off-by: marcin mikołajczak <git@mkljczk.pl>
2024-04-06Add hint to rulesmarcin mikołajczak
Signed-off-by: marcin mikołajczak <git@mkljczk.pl>
2024-04-06/api/v1/accounts/familiar_followersmarcin mikołajczak
Signed-off-by: marcin mikołajczak <git@mkljczk.pl>
2024-04-06Merge remote-tracking branch 'origin/develop' into instance_rulesmarcin mikołajczak
2024-03-20Merge branch 'bookmark-folders' into 'develop'lain
Fix BookmarkFolderView, add test See merge request pleroma/pleroma!4096
2024-03-20Fix BookmarkFolderView, add testmarcin mikołajczak
Signed-off-by: marcin mikołajczak <git@mkljczk.pl>
2024-03-19logger: remove request_id metadata which is not usefulMark Felder
2024-03-19Show Logger metadata in devMark Felder
2024-03-19Logger metadata for request path and authenticated userMark Felder
2024-03-19Logger metadata for inbound federation requestsMark Felder
2024-03-19MediaHelper: cache failed URLs for 15 minutes to prevent excessive retriesMark Felder
2024-03-19Skip generating notifications for internal usersMark Felder
2024-03-19Unify notification push and streaming events for both local and federated ↵Mark Felder
activities This also removes generation of notifications for blocked/filtered/muted users and threads.
2024-03-19Merge branch 'transient-validators-defaults' into 'develop'lain
Set defaults values on transient objects (attachment, poll options) validators See merge request pleroma/pleroma!4090
2024-03-19Merge branch 'develop' of git.pleroma.social:pleroma/pleroma into ↵Lain Soykaf
transient-validators-defaults
2024-03-19Update transient-validators-defaults.changelain
2024-03-19Merge branch 'fix-bookmark-test' into 'develop'lain
CI: Move changelog check to later in the pipeline See merge request pleroma/pleroma!4095
2024-03-19Add changelogLain Soykaf
2024-03-19CI: Move changelog check to later in the pipelineLain Soykaf
No reason to not run tests.
2024-03-19Tests: Actually run the bookmark folder tests.Lain Soykaf
2024-03-19Merge branch 'test-improvements' into 'develop'lain
Tests: Explicitly set db pool size and max cases to the same value. See merge request pleroma/pleroma!4094
2024-03-19Tests: Reduced the max case number to make tests more stable.Lain Soykaf