Age | Commit message (Collapse) | Author | |
---|---|---|---|
2024-01-29 | Pleroma.Web.MediaProxy.MediaProxyController: dialyzer errors | Mark Felder | |
lib/pleroma/web/media_proxy/media_proxy_controller.ex:55:no_return Function handle_preview/2 has no local return. ________________________________________________________________________________ lib/pleroma/web/media_proxy/media_proxy_controller.ex:59:call The function call will not succeed. Pleroma.HTTP.request(<<72, 69, 65, 68>>, _media_proxy_url :: any(), [], [], [{:pool, :media}]) will never return since the success typing is: ( :delete | :get | :head | :options | :patch | :post | :put | :trace, binary(), any(), [{binary(), binary()}], Keyword.t() ) :: any() and the contract is ( method(), Pleroma.HTTP.Request.url(), String.t(), Pleroma.HTTP.Request.headers(), :elixir.keyword() ) :: {:ok, Tesla.Env.t()} | {:error, any()} ________________________________________________________________________________ lib/pleroma/web/media_proxy/media_proxy_controller.ex:95:unused_fun Function handle_preview/3 will never be called. ________________________________________________________________________________ lib/pleroma/web/media_proxy/media_proxy_controller.ex:111:unused_fun Function handle_png_preview/2 will never be called. ________________________________________________________________________________ lib/pleroma/web/media_proxy/media_proxy_controller.ex:134:unused_fun Function handle_jpeg_preview/2 will never be called. ________________________________________________________________________________ lib/pleroma/web/media_proxy/media_proxy_controller.ex:152:unused_fun Function handle_video_preview/2 will never be called. ________________________________________________________________________________ lib/pleroma/web/media_proxy/media_proxy_controller.ex:164:unused_fun Function drop_static_param_and_redirect/1 will never be called. ________________________________________________________________________________ lib/pleroma/web/media_proxy/media_proxy_controller.ex:173:unused_fun Function fallback_on_preview_error/2 will never be called. ________________________________________________________________________________ lib/pleroma/web/media_proxy/media_proxy_controller.ex:177:unused_fun Function put_preview_response_headers/1 will never be called. ________________________________________________________________________________ lib/pleroma/web/media_proxy/media_proxy_controller.ex:177:unused_fun Function put_preview_response_headers/2 will never be called. ________________________________________________________________________________ lib/pleroma/web/media_proxy/media_proxy_controller.ex:187:unused_fun Function thumbnail_max_dimensions/0 will never be called. ________________________________________________________________________________ lib/pleroma/web/media_proxy/media_proxy_controller.ex:196:unused_fun Function min_content_length_for_preview/0 will never be called. ________________________________________________________________________________ lib/pleroma/web/media_proxy/media_proxy_controller.ex:200:unused_fun Function media_preview_proxy_config/0 will never be called. | |||
2024-01-29 | Merge branch 'deps-bump' into 'develop' | Haelwenn | |
Bump dependencies See merge request pleroma/pleroma!4044 | |||
2024-01-27 | Pleroma.Web.AdminAPI.ConfigController: dialyzer error | Mark Felder | |
lib/pleroma/web/admin_api/controllers/config_controller.ex:162:call The function call will not succeed. Phoenix.Controller.render( _conn :: %{:body_params => %{:configs => _, _ => _}, _ => _}, <<105, 110, 100, 101, 120, 46, 106, 115, 111, 110>>, %{:configs => [any()], :need_reboot => _} ) will never return since the success typing is: ( %Plug.Conn{ :adapter => {atom(), _}, :assigns => %{atom() => _}, :body_params => %Plug.Conn.Unfetched{:aspect => atom(), binary() => _}, :cookies => %Plug.Conn.Unfetched{:aspect => atom(), binary() => _}, :halted => boolean(), :host => binary(), :method => binary(), :owner => pid(), :params => %Plug.Conn.Unfetched{:aspect => atom(), binary() => _}, :path_info => [binary()], :path_params => %{binary() => binary() | [any()] | map()}, :port => char(), :private => %{atom() => _}, :query_params => %Plug.Conn.Unfetched{ :aspect => atom(), binary() => binary() | [any()] | map() }, :query_string => binary(), :remote_ip => {byte(), byte(), byte(), byte()} | {char(), char(), char(), char(), char(), char(), char(), char()}, :req_cookies => %Plug.Conn.Unfetched{:aspect => atom(), binary() => binary()}, :req_headers => [{_, _}], :request_path => binary(), :resp_body => nil | binary() | maybe_improper_list( binary() | maybe_improper_list(any(), binary() | []) | byte(), binary() | [] ), :resp_cookies => %{binary() => map()}, :resp_headers => [{_, _}], :scheme => :http | :https, :script_name => [binary()], :secret_key_base => nil | binary(), :state => :chunked | :file | :sent | :set | :set_chunked | :set_file | :unset | :upgraded, :status => nil | non_neg_integer() }, atom() | binary(), atom() | binary() | [{_, _}] | map() ) :: %Plug.Conn{ :adapter => {atom(), _}, :assigns => %{atom() => _}, :body_params => %Plug.Conn.Unfetched{:aspect => atom(), binary() => _}, :cookies => %Plug.Conn.Unfetched{:aspect => atom(), binary() => _}, :halted => boolean(), :host => binary(), :method => binary(), :owner => pid(), :params => %Plug.Conn.Unfetched{:aspect => atom(), binary() => _}, :path_info => [binary()], :path_params => %{binary() => binary() | [any()] | map()}, :port => char(), :private => %{atom() => _}, :query_params => %Plug.Conn.Unfetched{ :aspect => atom(), binary() => binary() | [any()] | map() }, :query_string => binary(), :remote_ip => {byte(), byte(), byte(), byte()} | {char(), char(), char(), char(), char(), char(), char(), char()}, :req_cookies => %Plug.Conn.Unfetched{:aspect => atom(), binary() => binary()}, :req_headers => [{_, _}], :request_path => binary(), :resp_body => nil | binary() | maybe_improper_list( binary() | maybe_improper_list(any(), binary() | []) | byte(), binary() | [] ), :resp_cookies => %{binary() => map()}, :resp_headers => [{_, _}], :scheme => :http | :https, :script_name => [binary()], :secret_key_base => nil | binary(), :state => :sent, :status => nil | non_neg_integer() } and the contract is (Plug.Conn.t(), binary() | atom(), Keyword.t() | map()) :: Plug.Conn.t() | |||
2024-01-26 | Pleroma.Signature: dialyzer error | Mark Felder | |
lib/pleroma/signature.ex:30:pattern_match The pattern can never match the type. Pattern: %{<<97, 112, 95, 105, 100>> => _ap_id} Type: {:error, _} | {:ok, map()} | |||
2024-01-26 | RichMedia.Parser.TTL.AwsSignedUrl: dialyzer fix | Mark Felder | |
lib/pleroma/web/rich_media/parser/ttl/aws_signed_url.ex:9:callback_type_mismatch Type mismatch for @callback ttl/2 in Pleroma.Web.RichMedia.Parser.TTL behaviour. Expected type: nil | integer() Actual type: {:error, <<_::64, _::size(8)>>} | {:ok, integer()} | |||
2024-01-26 | Credo.Check.Readability.PredicateFunctionNames | Mark Felder | |
This check was recently improved in Credo and it does make sense for readability. The offending functions in Pleroma have been renamed and a couple missing the ? suffix have been fixed as well. | |||
2024-01-19 | Merge branch 'handle_object_fetch_failures' into 'develop' | Haelwenn | |
Handle object fetch failures gracefully See merge request pleroma/pleroma!4015 | |||
2024-01-17 | Merge branch 'otp26' into 'develop' | Haelwenn | |
OTP26 support See merge request pleroma/pleroma!4025 | |||
2024-01-15 | Skip tests on MacOS/Darwin that have always failed | Mark Felder | |
2024-01-16 | Pleroma.Web.MastodonAPI.SubscriptionControllerTest: disable async and use ↵ | Mark Felder | |
on_exit/1 to ensure web push config gets restored | |||
2024-01-15 | Fix StatusController test by using the get_query_parameter/2 helper to ↵ | Mark Felder | |
reliably retrieve the max_id value | |||
2024-01-15 | Add Pleroma.Test.Helpers.get_query_parameter/2 to retrieve specific query ↵ | Mark Felder | |
parameter values | |||
2024-01-15 | Fix ChatController tests validating prev/next URLs by sorting the query ↵ | Mark Felder | |
parameters before comparison | |||
2024-01-15 | Add Pleroma.Support.Helpers.uri_query_sort/1 for easy sorting of a URL's ↵ | Mark Felder | |
query parameters | |||
2024-01-15 | Merge branch 'mrf-regex-error' into 'develop' | Haelwenn | |
MRF: Log sensible regex error for subdomain_match See merge request pleroma/pleroma!4026 | |||
2024-01-15 | Merge branch 'mrf-steal-emoji-extname' into 'develop' | Haelwenn | |
MRF.StealEmojiPolicy: Properly add fallback extension to filenames missing one See merge request pleroma/pleroma!4029 | |||
2024-01-14 | Allow the Remote Fetcher to attempt fetching an unreachable instance | Mark Felder | |
2024-01-13 | Merge branch 'nil-contentMap' into 'develop' | tusooa | |
Support objects with a nil contentMap (firefish) Closes #3231 See merge request pleroma/pleroma!4030 | |||
2024-01-11 | Add test to validate shared inboxes are used when multiple recipients from ↵ | Mark Felder | |
the same instance are recipients | |||
2024-01-11 | Support objects with a nil contentMap (firefish) | Haelwenn (lanodan) Monnier | |
Closes: https://git.pleroma.social/pleroma/pleroma/-/issues/3231 | |||
2024-01-07 | MRF.StealEmojiPolicy: Properly add fallback extension to filenames missing one | Haelwenn (lanodan) Monnier | |
2024-01-07 | Fix tests | Ekaterina Vaartis | |
2024-01-02 | MRF: Log sensible error for subdomains_regex | Haelwenn (lanodan) Monnier | |
2023-12-30 | Linting | Lain Soykaf | |
2023-12-29 | Revert grammar leak from bad merge | Mark Felder | |
2023-12-29 | ConfigDB export to file does not have a consistent order. | Mark Felder | |
Just test a few values to prove it was written | |||
2023-12-29 | Fix regex string match due to OTP26 key order change | Mark Felder | |
OTP25: "<http://localhost:4001/api/v1/favourites?limit=1&max_id=Ad1FhzPIS7gcHjUcoC&offset=0>; rel=\"next\"" OTP26: "<http://localhost:4001/api/v1/favourites?offset=0&limit=1&max_id=Ad1FmOIAXiSNgygflA>; rel=\"next\"" | |||
2023-12-29 | Fix Chat controller tests failing due to OTP26 key order change | Mark Felder | |
2023-12-29 | Remove call to Pleroma.Web.Endpoint.config_change/2 | Mark Felder | |
This is not necessary for the tests to pass and breaks other tests as this change doesn't get cleanly reverted causing the hostname to stay set this way and leak into other test causing failures with "sub.example.com" not matching "localhost" | |||
2023-12-29 | Fix test "transforms config to tuples" | Mark Felder | |
This should have never worked. The default empty values for the other MRF Simple options will always be there. | |||
2023-12-29 | Update Floki to get the :attributes_as_maps feature to allow us to compare ↵ | Mark Felder | |
equality of parsed documents without issues of key ordering | |||
2023-12-29 | Implement a custom uri_equal?/2 to fix comparisons of URLs with unordered ↵ | Mark Felder | |
query parameters | |||
2023-12-29 | Fix tests by leveraging Keyword.equal?/2 | Mark Felder | |
2023-12-29 | Merge branch 'publisher' into 'develop' | Haelwenn | |
Discard some failed publisher jobs See merge request pleroma/pleroma!4022 | |||
2023-12-29 | Fix tests | Mark Felder | |
Need to handle the edge case of no valid HTTP response which has no status code | |||
2023-12-29 | Merge branch 'bugfix/chat-attachment-empty-array' into 'develop' | lain | |
ChatMessage: Tolerate attachment field set to an empty array Closes #3224 See merge request pleroma/pleroma!4020 | |||
2023-12-28 | Oban jobs should be discarded on permanent errors | Mark Felder | |
2023-12-29 | ChatMessage: Tolerate attachment field set to an empty array | Haelwenn (lanodan) Monnier | |
Closes: https://git.pleroma.social/pleroma/pleroma/-/issues/3224 | |||
2023-12-28 | Remove reference to the :federation_publisher_modules setting in our config test | Mark Felder | |
2023-12-28 | Retire the Pleroma.Web.Federator.Publisher module | Mark Felder | |
2023-12-28 | Merge branch 'tusooa/3205-group-actor' into 'develop' | Haelwenn | |
Implement group actors See merge request pleroma/pleroma!3969 | |||
2023-12-27 | Improve test descriptions | Mark Felder | |
2023-12-27 | Prevent requeuing Remote Fetcher jobs that exceed thread depth | Mark Felder | |
2023-12-27 | Leverage existing atoms as return errors for the object fetcher | Mark Felder | |
2023-12-27 | Conslidate log messages for object fetcher failures and leverage Logger.metadata | Mark Felder | |
2023-12-28 | Fix some more typos | marcin mikołajczak | |
Signed-off-by: marcin mikołajczak <git@mkljczk.pl> | |||
2023-12-27 | RemoteFetcherWorker Oban job tests | Mark Felder | |
2023-12-27 | Do not boost if group is blocking poster | tusooa | |
2023-12-27 | Test group actor behaviour in SideEffects | tusooa | |
2023-12-27 | Allow group actors to boost posts | tusooa | |