| Age | Commit message (Collapse) | Author |
|---|
|
Before we deleted the notifications, but that was a side effect and didn't always trigger any more.
Now we just hide them when an unprivileged user asks them.
|
|
This reverts commit 89667189b840fc79d85336739e6b2512684d7be0 and cdc5bbe8369d4fc66d642bb3e845a237d11e34d7.
This is a side effect when changing user role.
The goal was to not have report notifications when someone isn't admin or moderator any more.
But this won't be triggered when we change the privilege tags for a role, so we can't use this sollution any more.
There was another solution to filter out report notifications during fetch.
It wasn't merged because this seemed 'cleaner' at the time, but now it seems the better sollution.
I'll add it in the next commit.
|
|
According to the tests, this was only used for unconfirmed accounts.
So this just needed to be restricted to users with privilege :user_activation
|
|
superuser
|
|
Instead of superusers, you now need a role with privilige :status_delete to delete other users statusses
I also cleaned up some other stuff I saw
|
|
This should eventually replace Pleroma.User.superuser?/1
|
|
Fixed the warning
[warning] Please change `clear_config([section], key: value)` to `clear_config([section, key], value)`
|
|
I still had three endpoints I didn't really know what to do with them. I added them under separate tags
* :instance_delete
* :moderation_log_read
* :stats_read
I also checked and these are the last changes done by MR https://git.pleroma.social/pleroma/pleroma/-/merge_requests/3480/diffs this is trying to fix
|
|
|
|
It also allows to update a message, so it's not just deleting. I need a better name...
|
|
From the endpoints left to do, I believe these should be under :statuses_read.
These should be the last for that privilege for this MR
|
|
One of the things we do during the tests is change the config. But that's global state and different tests were interfering.
E.g. one test would set `clear_config([:instance, :admin_privileges], [:statuses_read])`, but while that runs, another test may
do `clear_config([:instance, :admin_privileges], [:user_invite])`. Now the code for the first test checks the setting, and it
finds `:user_invite` instead of `:statuses_read`.
Now the modules where this happens are marked to run synchronously, so they don't interfere with each other.
|
|
|
|
|
|
|
|
|
|
|
|
Everything that was done through this setting, can now be set by giving the proper privileges to the roles.
|
|
This was the last in :require_privileged_staff. I'll remove that in the next commit
|
|
I only moved the ones from the :require_privileged_staff block for now
|
|
|
|
|
|
|
|
get_create_by_ap_id_with_object() seems to fetch the old object.
Why this happens needs further investigation.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Signed-off-by: marcin mikołajczak <git@mkljczk.pl>
|
|
Signed-off-by: marcin mikołajczak <git@mkljczk.pl>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
* rejected_shortcodes is defined as a list of strings in the
configuration description. As such, database-based configuration was
led to handle those settings as strings, and not as the actually
expected type, Regex.
* This caused each message passing through this MRF, if a rejected
shortcode was set and the emoji did not exist already on the instance,
to fail federating, as an exception was raised, swiftly caught and
mostly silenced.
* This commit fixes the issue by introducing new behavior: strings are
now handled as perfect matches for an emoji shortcode (meaning that if
the emoji-to-be-pulled's shortcode is in the blacklist, it will be
rejected), while still supporting Regex types as before.
|
