From 45646ff52cd045485c6be92713edcd0b37225bc3 Mon Sep 17 00:00:00 2001
From: silverpill <silverpill@firemail.cc>
Date: Thu, 29 Dec 2022 23:57:19 +0000
Subject: TagValidator: Add test for Link tag

---
 test/fixtures/fep-e232.json                        | 26 ++++++++++++++++++++++
 .../web/activity_pub/transmogrifier_test.exs       | 16 +++++++++++++
 2 files changed, 42 insertions(+)
 create mode 100644 test/fixtures/fep-e232.json

(limited to 'test')

diff --git a/test/fixtures/fep-e232.json b/test/fixtures/fep-e232.json
new file mode 100644
index 000000000..98f339589
--- /dev/null
+++ b/test/fixtures/fep-e232.json
@@ -0,0 +1,26 @@
+{
+  "@context": "https://www.w3.org/ns/activitystreams",
+  "type": "Create",
+  "actor": "https://example.org/users/alice",
+  "object": {
+    "id": "https://example.org/objects/10",
+    "type": "Note",
+    "attributedTo": "https://example.org/users/alice",
+    "content": "<p>test <a href=\"https://example.org/objects/9\">https://example.org/objects/9</a></p>",
+    "published": "2022-10-01T21:30:05.211215Z",
+    "tag": [
+      {
+        "name": "https://example.org/objects/9",
+        "type": "Link",
+        "href": "https://example.org/objects/9",
+        "mediaType": "application/ld+json; profile=\"https://www.w3.org/ns/activitystreams\""
+      }
+    ],
+    "to": [
+      "https://www.w3.org/ns/activitystreams#Public"
+    ],
+    "cc": [
+      "https://example.org/users/alice/followers"
+    ]
+  }
+}
diff --git a/test/pleroma/web/activity_pub/transmogrifier_test.exs b/test/pleroma/web/activity_pub/transmogrifier_test.exs
index 6b4636d22..c0425f30c 100644
--- a/test/pleroma/web/activity_pub/transmogrifier_test.exs
+++ b/test/pleroma/web/activity_pub/transmogrifier_test.exs
@@ -123,6 +123,22 @@ defmodule Pleroma.Web.ActivityPub.TransmogrifierTest do
 
       assert activity.data["context"] == object.data["context"]
     end
+
+    # https://codeberg.org/fediverse/fep/src/branch/main/feps/fep-e232.md
+    test "it accepts FEP-e232 link tags" do
+      insert(:user, ap_id: "https://example.org/users/alice")
+
+      message = File.read!("test/fixtures/fep-e232.json") |> Jason.decode!()
+
+      assert {:ok, activity} = Transmogrifier.handle_incoming(message)
+
+      object = Object.normalize(activity)
+      assert length(object.data["tag"]) == 1
+
+      tag = object.data["tag"] |> List.first()
+      assert tag["type"] == "Link"
+      assert tag["name"] == "https://example.org/objects/9"
+    end
   end
 
   describe "prepare outgoing" do
-- 
cgit v1.2.3


From 5cfb0578a6845db377b5679ac05aa25ee5656211 Mon Sep 17 00:00:00 2001
From: silverpill <silverpill@firemail.cc>
Date: Fri, 30 Dec 2022 17:26:43 +0000
Subject: TagValidator: Drop unrecognized tags

---
 test/fixtures/fep-e232.json                           | 5 +++++
 test/pleroma/web/activity_pub/transmogrifier_test.exs | 6 ++----
 2 files changed, 7 insertions(+), 4 deletions(-)

(limited to 'test')

diff --git a/test/fixtures/fep-e232.json b/test/fixtures/fep-e232.json
index 98f339589..e9d12ae35 100644
--- a/test/fixtures/fep-e232.json
+++ b/test/fixtures/fep-e232.json
@@ -9,6 +9,11 @@
     "content": "<p>test <a href=\"https://example.org/objects/9\">https://example.org/objects/9</a></p>",
     "published": "2022-10-01T21:30:05.211215Z",
     "tag": [
+      {
+        "name": "@bob@example.net",
+        "type": "Mention",
+        "href": "https://example.net/users/bob"
+      },
       {
         "name": "https://example.org/objects/9",
         "type": "Link",
diff --git a/test/pleroma/web/activity_pub/transmogrifier_test.exs b/test/pleroma/web/activity_pub/transmogrifier_test.exs
index c0425f30c..f76606479 100644
--- a/test/pleroma/web/activity_pub/transmogrifier_test.exs
+++ b/test/pleroma/web/activity_pub/transmogrifier_test.exs
@@ -124,8 +124,7 @@ defmodule Pleroma.Web.ActivityPub.TransmogrifierTest do
       assert activity.data["context"] == object.data["context"]
     end
 
-    # https://codeberg.org/fediverse/fep/src/branch/main/feps/fep-e232.md
-    test "it accepts FEP-e232 link tags" do
+    test "it drops link tags" do
       insert(:user, ap_id: "https://example.org/users/alice")
 
       message = File.read!("test/fixtures/fep-e232.json") |> Jason.decode!()
@@ -136,8 +135,7 @@ defmodule Pleroma.Web.ActivityPub.TransmogrifierTest do
       assert length(object.data["tag"]) == 1
 
       tag = object.data["tag"] |> List.first()
-      assert tag["type"] == "Link"
-      assert tag["name"] == "https://example.org/objects/9"
+      assert tag["type"] == "Mention"
     end
   end
 
-- 
cgit v1.2.3