From 9617189e963b89f4353168e20d48ff086a0c53bb Mon Sep 17 00:00:00 2001 From: Lain Soykaf Date: Tue, 19 Mar 2024 13:51:04 +0400 Subject: Tests: Actually run the bookmark folder tests. --- .../controllers/bookmark_folder_controller_test.ex | 148 --------------------- .../bookmark_folder_controller_test.exs | 148 +++++++++++++++++++++ 2 files changed, 148 insertions(+), 148 deletions(-) delete mode 100644 test/pleroma/web/pleroma_api/controllers/bookmark_folder_controller_test.ex create mode 100644 test/pleroma/web/pleroma_api/controllers/bookmark_folder_controller_test.exs (limited to 'test') diff --git a/test/pleroma/web/pleroma_api/controllers/bookmark_folder_controller_test.ex b/test/pleroma/web/pleroma_api/controllers/bookmark_folder_controller_test.ex deleted file mode 100644 index 71b850859..000000000 --- a/test/pleroma/web/pleroma_api/controllers/bookmark_folder_controller_test.ex +++ /dev/null @@ -1,148 +0,0 @@ -# Pleroma: A lightweight social networking server -# Copyright © 2017-2024 Pleroma Authors -# SPDX-License-Identifier: AGPL-3.0-only -defmodule Pleroma.Web.PleromaAPI.BookmarkFolderControllerTest do - use Pleroma.Web.ConnCase - - alias Pleroma.BookmarkFolder - # alias Pleroma.Object - # alias Pleroma.Tests.Helpers - # alias Pleroma.UnstubbedConfigMock, as: ConfigMock - # alias Pleroma.User - # alias Pleroma.Web.ActivityPub.ActivityPub - # alias Pleroma.Web.CommonAPI - - # import Mox - import Pleroma.Factory - - describe "GET /api/v1/pleroma/bookmark_folders" do - setup do: oauth_access(["read:bookmarks"]) - - test "it lists bookmark folders", %{conn: conn, user: user} do - {:ok, folder} = BookmarkFolder.create(user.id, "Bookmark folder") - - folder_id = folder.id - - result = - conn - |> get("/api/v1/pleroma/bookmark_folders") - |> json_response_and_validate_schema(200) - - assert [ - %{ - "id" => ^folder_id, - "name" => "Bookmark folder", - "emoji" => nil, - "source" => %{ - "emoji" => nil - } - } - ] = result - end - end - - describe "POST /api/v1/pleroma/bookmark_folders" do - setup do: oauth_access(["write:bookmarks"]) - - test "it creates a bookmark folder", %{conn: conn} do - result = - conn - |> put_req_header("content-type", "application/json") - |> post("/api/v1/pleroma/bookmark_folders", %{ - name: "Bookmark folder", - emoji: "📁" - }) - |> json_response_and_validate_schema(200) - - assert %{ - "name" => "Bookmark folder", - "emoji" => "📁", - "source" => %{ - "emoji" => "📁" - } - } = result - end - - test "it returns error for invalid emoji", %{conn: conn} do - result = - conn - |> put_req_header("content-type", "application/json") - |> post("/api/v1/pleroma/bookmark_folders", %{ - name: "Bookmark folder", - emoji: "not an emoji" - }) - |> json_response_and_validate_schema(422) - - assert %{"error" => "Invalid emoji"} = result - end - end - - describe "PATCH /api/v1/pleroma/bookmark_folders/:id" do - setup do: oauth_access(["write:bookmarks"]) - - test "it updates a bookmark folder", %{conn: conn, user: user} do - {:ok, folder} = BookmarkFolder.create(user.id, "Bookmark folder") - - result = - conn - |> put_req_header("content-type", "application/json") - |> patch("/api/v1/pleroma/bookmark_folders/#{folder.id}", %{ - name: "bookmark folder" - }) - |> json_response_and_validate_schema(200) - - assert %{ - "name" => "bookmark folder" - } = result - end - - test "it returns error when updating others' folders", %{conn: conn} do - other_user = insert(:user) - - {:ok, folder} = BookmarkFolder.create(other_user.id, "Bookmark folder") - - result = - conn - |> put_req_header("content-type", "application/json") - |> patch("/api/v1/pleroma/bookmark_folders/#{folder.id}", %{ - name: "bookmark folder" - }) - |> json_response_and_validate_schema(403) - - assert %{ - "error" => "Access denied" - } = result - end - end - - describe "DELETE /api/v1/pleroma/bookmark_folders/:id" do - setup do: oauth_access(["write:bookmarks"]) - - test "it deleting a bookmark folder", %{conn: conn, user: user} do - {:ok, folder} = BookmarkFolder.create(user.id, "Bookmark folder") - - assert conn - |> delete("/api/v1/pleroma/bookmark_folders/#{folder.id}") - |> json_response_and_validate_schema(200) - - folders = BookmarkFolder.for_user(user.id) - - assert length(folders) == 0 - end - - test "it returns error when deleting others' folders", %{conn: conn} do - other_user = insert(:user) - - {:ok, folder} = BookmarkFolder.create(other_user.id, "Bookmark folder") - - result = - conn - |> patch("/api/v1/pleroma/bookmark_folders/#{folder.id}") - |> json_response_and_validate_schema(403) - - assert %{ - "error" => "Access denied" - } = result - end - end -end diff --git a/test/pleroma/web/pleroma_api/controllers/bookmark_folder_controller_test.exs b/test/pleroma/web/pleroma_api/controllers/bookmark_folder_controller_test.exs new file mode 100644 index 000000000..71b850859 --- /dev/null +++ b/test/pleroma/web/pleroma_api/controllers/bookmark_folder_controller_test.exs @@ -0,0 +1,148 @@ +# Pleroma: A lightweight social networking server +# Copyright © 2017-2024 Pleroma Authors +# SPDX-License-Identifier: AGPL-3.0-only +defmodule Pleroma.Web.PleromaAPI.BookmarkFolderControllerTest do + use Pleroma.Web.ConnCase + + alias Pleroma.BookmarkFolder + # alias Pleroma.Object + # alias Pleroma.Tests.Helpers + # alias Pleroma.UnstubbedConfigMock, as: ConfigMock + # alias Pleroma.User + # alias Pleroma.Web.ActivityPub.ActivityPub + # alias Pleroma.Web.CommonAPI + + # import Mox + import Pleroma.Factory + + describe "GET /api/v1/pleroma/bookmark_folders" do + setup do: oauth_access(["read:bookmarks"]) + + test "it lists bookmark folders", %{conn: conn, user: user} do + {:ok, folder} = BookmarkFolder.create(user.id, "Bookmark folder") + + folder_id = folder.id + + result = + conn + |> get("/api/v1/pleroma/bookmark_folders") + |> json_response_and_validate_schema(200) + + assert [ + %{ + "id" => ^folder_id, + "name" => "Bookmark folder", + "emoji" => nil, + "source" => %{ + "emoji" => nil + } + } + ] = result + end + end + + describe "POST /api/v1/pleroma/bookmark_folders" do + setup do: oauth_access(["write:bookmarks"]) + + test "it creates a bookmark folder", %{conn: conn} do + result = + conn + |> put_req_header("content-type", "application/json") + |> post("/api/v1/pleroma/bookmark_folders", %{ + name: "Bookmark folder", + emoji: "📁" + }) + |> json_response_and_validate_schema(200) + + assert %{ + "name" => "Bookmark folder", + "emoji" => "📁", + "source" => %{ + "emoji" => "📁" + } + } = result + end + + test "it returns error for invalid emoji", %{conn: conn} do + result = + conn + |> put_req_header("content-type", "application/json") + |> post("/api/v1/pleroma/bookmark_folders", %{ + name: "Bookmark folder", + emoji: "not an emoji" + }) + |> json_response_and_validate_schema(422) + + assert %{"error" => "Invalid emoji"} = result + end + end + + describe "PATCH /api/v1/pleroma/bookmark_folders/:id" do + setup do: oauth_access(["write:bookmarks"]) + + test "it updates a bookmark folder", %{conn: conn, user: user} do + {:ok, folder} = BookmarkFolder.create(user.id, "Bookmark folder") + + result = + conn + |> put_req_header("content-type", "application/json") + |> patch("/api/v1/pleroma/bookmark_folders/#{folder.id}", %{ + name: "bookmark folder" + }) + |> json_response_and_validate_schema(200) + + assert %{ + "name" => "bookmark folder" + } = result + end + + test "it returns error when updating others' folders", %{conn: conn} do + other_user = insert(:user) + + {:ok, folder} = BookmarkFolder.create(other_user.id, "Bookmark folder") + + result = + conn + |> put_req_header("content-type", "application/json") + |> patch("/api/v1/pleroma/bookmark_folders/#{folder.id}", %{ + name: "bookmark folder" + }) + |> json_response_and_validate_schema(403) + + assert %{ + "error" => "Access denied" + } = result + end + end + + describe "DELETE /api/v1/pleroma/bookmark_folders/:id" do + setup do: oauth_access(["write:bookmarks"]) + + test "it deleting a bookmark folder", %{conn: conn, user: user} do + {:ok, folder} = BookmarkFolder.create(user.id, "Bookmark folder") + + assert conn + |> delete("/api/v1/pleroma/bookmark_folders/#{folder.id}") + |> json_response_and_validate_schema(200) + + folders = BookmarkFolder.for_user(user.id) + + assert length(folders) == 0 + end + + test "it returns error when deleting others' folders", %{conn: conn} do + other_user = insert(:user) + + {:ok, folder} = BookmarkFolder.create(other_user.id, "Bookmark folder") + + result = + conn + |> patch("/api/v1/pleroma/bookmark_folders/#{folder.id}") + |> json_response_and_validate_schema(403) + + assert %{ + "error" => "Access denied" + } = result + end + end +end -- cgit v1.2.3