From 5e7f4f687e55813059176d6046ac32c35e0e0738 Mon Sep 17 00:00:00 2001 From: Mark Felder Date: Wed, 8 May 2024 13:52:25 -0400 Subject: Improve StatusView tests for Cards --- test/pleroma/web/mastodon_api/views/status_view_test.exs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'test') diff --git a/test/pleroma/web/mastodon_api/views/status_view_test.exs b/test/pleroma/web/mastodon_api/views/status_view_test.exs index 663610442..c1313eb1b 100644 --- a/test/pleroma/web/mastodon_api/views/status_view_test.exs +++ b/test/pleroma/web/mastodon_api/views/status_view_test.exs @@ -738,7 +738,7 @@ defmodule Pleroma.Web.MastodonAPI.StatusViewTest do {:ok, card} = Card.create(page_url, %{image: page_url <> "/example.jpg", title: "Example website"}) - %{provider_name: "example.com"} = StatusView.render("card.json", card) + assert match?(%{provider_name: "example.com"}, StatusView.render("card.json", card)) end test "a rich media card without a site name or image renders correctly" do @@ -751,7 +751,7 @@ defmodule Pleroma.Web.MastodonAPI.StatusViewTest do {:ok, card} = Card.create(page_url, fields) - %{provider_name: "example.com"} = StatusView.render("card.json", card) + assert match?(%{provider_name: "example.com"}, StatusView.render("card.json", card)) end test "a rich media card without an image renders correctly" do @@ -765,7 +765,7 @@ defmodule Pleroma.Web.MastodonAPI.StatusViewTest do {:ok, card} = Card.create(page_url, fields) - %{provider_name: "example.com"} = StatusView.render("card.json", card) + assert match?(%{provider_name: "example.com"}, StatusView.render("card.json", card)) end test "a rich media card with all relevant data renders correctly" do @@ -781,7 +781,7 @@ defmodule Pleroma.Web.MastodonAPI.StatusViewTest do {:ok, card} = Card.create(page_url, fields) - %{provider_name: "example.com"} = StatusView.render("card.json", card) + assert match?(%{provider_name: "example.com"}, StatusView.render("card.json", card)) end test "a rich media card has all media proxied" do -- cgit v1.2.3 From ccceb41bf3f50ce914c16c2a18ec882e97309214 Mon Sep 17 00:00:00 2001 From: Mark Felder Date: Wed, 8 May 2024 13:54:57 -0400 Subject: Add test for StatusView rendering of Cards when missing descriptions --- .../pleroma/web/mastodon_api/views/status_view_test.exs | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) (limited to 'test') diff --git a/test/pleroma/web/mastodon_api/views/status_view_test.exs b/test/pleroma/web/mastodon_api/views/status_view_test.exs index c1313eb1b..1c2d7f7fd 100644 --- a/test/pleroma/web/mastodon_api/views/status_view_test.exs +++ b/test/pleroma/web/mastodon_api/views/status_view_test.exs @@ -768,6 +768,23 @@ defmodule Pleroma.Web.MastodonAPI.StatusViewTest do assert match?(%{provider_name: "example.com"}, StatusView.render("card.json", card)) end + test "a rich media card without descriptions returns the fields with empty strings" do + page_url = "https://example.com" + + fields = %{ + "url" => page_url, + "site_name" => "Example site name", + "title" => "Example website" + } + + {:ok, card} = Card.create(page_url, fields) + + assert match?( + %{description: "", image_description: ""}, + StatusView.render("card.json", card) + ) + end + test "a rich media card with all relevant data renders correctly" do page_url = "https://example.com" -- cgit v1.2.3