otp_version refactor

1 files changed, 11 insertions, 31 deletions

diff --git a/test/otp_version_test.exs b/test/otp_version_test.exs
index f26b90f61..af278cc72 100644
--- a/test/otp_version_test.exs
+++ b/test/otp_version_test.exs
@@ -1,58 +1,38 @@
+# Pleroma: A lightweight social networking server
+# Copyright © 2017-2020 Pleroma Authors <https://pleroma.social/>
+# SPDX-License-Identifier: AGPL-3.0-only
+
 defmodule Pleroma.OTPVersionTest do
   use ExUnit.Case, async: true
 
   alias Pleroma.OTPVersion
 
-  describe "get_and_check_version/2" do
+  describe "check/1" do
     test "22.4" do
-      assert OTPVersion.get_and_check_version(Tesla.Adapter.Gun, [
-               "test/fixtures/warnings/otp_version/22.4"
-             ]) == :ok
+      assert OTPVersion.check(["test/fixtures/warnings/otp_version/22.4"]) == :ok
     end
 
     test "22.1" do
-      assert OTPVersion.get_and_check_version(Tesla.Adapter.Gun, [
-               "test/fixtures/warnings/otp_version/22.1"
-             ]) == {:error, "22.1"}
+      assert OTPVersion.check(["test/fixtures/warnings/otp_version/22.1"]) == {:error, "22.1"}
     end
 
     test "21.1" do
-      assert OTPVersion.get_and_check_version(Tesla.Adapter.Gun, [
-               "test/fixtures/warnings/otp_version/21.1"
-             ]) == {:error, "21.1"}
+      assert OTPVersion.check(["test/fixtures/warnings/otp_version/21.1"]) == {:error, "21.1"}
     end
 
     test "23.0" do
-      assert OTPVersion.get_and_check_version(Tesla.Adapter.Gun, [
-               "test/fixtures/warnings/otp_version/23.0"
-             ]) == :ok
-    end
-
-    test "undefined" do
-      assert OTPVersion.get_and_check_version(Tesla.Adapter.Gun, [
-               "test/fixtures/warnings/otp_version/undefined"
-             ]) == :undefined
-    end
-
-    test "not parsable" do
-      assert OTPVersion.get_and_check_version(Tesla.Adapter.Gun, [
-               "test/fixtures/warnings/otp_version/error"
-             ]) == :undefined
+      assert OTPVersion.check(["test/fixtures/warnings/otp_version/23.0"]) == :ok
     end
 
     test "with non existance file" do
-      assert OTPVersion.get_and_check_version(Tesla.Adapter.Gun, [
+      assert OTPVersion.check([
                "test/fixtures/warnings/otp_version/non-exising",
                "test/fixtures/warnings/otp_version/22.4"
              ]) == :ok
     end
 
     test "empty paths" do
-      assert OTPVersion.get_and_check_version(Tesla.Adapter.Gun, []) == :undefined
-    end
-
-    test "another adapter" do
-      assert OTPVersion.get_and_check_version(Tesla.Adapter.Hackney, []) == :ok
+      assert OTPVersion.check([]) == :undefined
     end
   end
 end